OLMIS-3108: Changes to build process across UI projects

Activity

FEOLMIS-2373 5

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 9m 2 Mateusz Kwiatkowski Yes, I think that would work.... let'...
    Reviewer - 100% reviewed 3m    
    Reviewer - Complete 4m 2 We could move sonar.sh file to dev-ui too
    Reviewer - Complete 4m 1 LGTM
    Total   20m 5  
    #permalink

    Objectives

    While implementing changes to transifex, I simplified the build process in each UI repository.

    I removed build.sh in preference in reusing a default created in dev-ui – since each one was identical

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    You forgot to remove build.sh from ui-components, ui-layout and requisition-ui

    You forgot to remove build.sh from ui-components, ui-layout and requisition-ui

    Nick Reid

    Done, good catch!

    Done, good catch!

    Mateusz Kwiatkowski

    We could move sonar.sh file to dev-ui too

    We could move sonar.sh file to dev-ui too

    Nick Reid

    Mateusz Kwiatkowski Yes, I think that would work.... let's chat about that ou...

    Mateusz Kwiatkowski Yes, I think that would work.... let's chat about that outside of this review

    /Dockerfile Changed
    /build.sh Added
    /config.json Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    /project.properties Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    /project.properties Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    Open in IDE #permalink
    /project.properties Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    Open in IDE #permalink
    /project.properties Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    Open in IDE #permalink
    /project.properties Changed
    /CHANGELOG.md Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    /project.properties Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    /project.properties Changed
    /CHANGELOG.md Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    /project.properties Changed
    /CHANGELOG.md Changed
    /Dockerfile Changed
    /build.sh Deleted
    Open in IDE #permalink
    /config.json Changed
    /project.properties Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against