OLMIS-3195: added sonar task

Activity

FEOLMIS-2278 19

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 2h 13m 8 I've created new ticket for dealing with running Karma te...
    Reviewer - Complete 7m 2 Yeah, it's definitely worth filling a new ticket for this...
    Reviewer - Complete 23m 3 because of missing this field sonar build fails
    Reviewer - Complete 11m 5 I've created OLMIS-3867 to do this
    Reviewer - Complete 14m 1 please update http://docs.openlmis.org/en/latest/conventi...
    Total   3h 8m 19  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    I know that there is a lot of files in this review so review just dev-ui chan...

    I know that there is a lot of files in this review so review just dev-ui changes and referencedata-ui, other modules are duplicated mostly

    Łukasz Lewczyński

    It would be great if we could move sonar.sh file to the dev-ui but I am not s...

    It would be great if we could move sonar.sh file to the dev-ui but I am not sure if this is possible.

    Mateusz Kwiatkowski

    That would be possible, but all dev-iu files are in /node_modules/dev-ui/ , I...

    That would be possible, but all dev-iu files are in /node_modules/dev-ui/ , I don't think we want to run script from there, but if you guys think otherwise I can move it there

    Nikodem Graczewski

    As long as this path won't change I'm totally OK with that to be honest...

    As long as this path won't change I'm totally OK with that to be honest...

    Mateusz Kwiatkowski

    It shouldn't change but who knows..... it is definitely more reliable to have...

    It shouldn't change but who knows..... it is definitely more reliable to have it in service repo itself. Maybe we should create a short ticket about moving build.sh and sonar.sh to dev-ui? I'm not sure what folks from VR will think about it

    Nikodem Graczewski

    Yeah, it's definitely worth filling a new ticket for this and move the discus...

    Yeah, it's definitely worth filling a new ticket for this and move the discussion there.

    Nick Reid

    Mateusz Kwiatkowski If the sonar.sh script is at /sonar.sh in the dev-ui, whe...

    Mateusz Kwiatkowski If the sonar.sh script is at /sonar.sh in the dev-ui, when built with docker it exists in the virtual machine's file system at /dev-ui/sonar.sh

    Nick Reid

    I've created OLMIS-3867 to do this

    I've created OLMIS-3867 to do this

    Mateusz Kwiatkowski

    I've created new ticket for dealing with running Karma tests with separate fi...

    I've created new ticket for dealing with running Karma tests with separate files: OLMIS-3844

    /tasks/karma.js Changed 4
    /tasks/sonar.js Added 3
    /CHANGELOG.md Added
    Open in IDE #permalink
    /Dockerfile Changed
    /package.json Changed
    /.gitignore Changed
    Open in IDE #permalink
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /.gitignore Changed
    Open in IDE #permalink
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /.gitignore Changed
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /docs/.../conventions/versioningReleasing.md Changed 1
    /.gitignore Changed
    /.gitignore Changed
    Open in IDE #permalink
    /docker-compose.yml Changed
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    /version.properties Deleted 1
    Open in IDE #permalink
    /.gitignore Changed
    Open in IDE #permalink
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /.gitignore Changed
    Open in IDE #permalink
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /.gitignore Changed
    Open in IDE #permalink
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /.gitignore Changed
    Open in IDE #permalink
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink
    /.gitignore Changed
    Open in IDE #permalink
    /docker-compose.yml Changed 1
    /project.properties Added
    Open in IDE #permalink
    /sonar.sh Added
    Open in IDE #permalink
    /version.properties Deleted
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against