OLMIS-3351: get rid of basic export methods

Activity

FEOLMIS-2099 9

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 42m 1 done
    Reviewer - 96% reviewed 9m    
    Reviewer - 100% reviewed 43m 7 since these are primitives (ints) I think it's fine to us...
    Reviewer - 0% reviewed      
    Reviewer - 71% reviewed 9m    
    Reviewer - Complete 7m 1 Agreed with Pawel G's comments and it looks like we're mo...
    Total   1h 50m 9  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Paweł Gesek

    Looks ok, but as I mentioned it does not fully follow the pattern. Some tweak...

    Looks ok, but as I mentioned it does not fully follow the pattern. Some tweaking is needed.

    Josh Zamor

    Agreed with Pawel G's comments and it looks like we're moving more and more c...

    Agreed with Pawel G's comments and it looks like we're moving more and more closely to the full pattern. Nicely done and thanks!

    /src/.../web/ReportsControllerIntegrationTest.java Changed
    /src/main/.../domain/Requisition.java Changed 3
    /src/main/.../domain/RequisitionLineItem.java Changed 1
    /src/main/.../dto/BasicRequisitionDto.java Changed
    /src/.../dto/BatchApproveRequisitionDto.java Added 1
    /src/.../dto/BatchApproveRequisitionLineItemDto.java Added 2
    /src/main/.../dto/RequisitionDto.java Changed
    /src/main/.../dto/RequisitionLineItemDto.java Changed
    /src/.../utils/RequisitionExportHelper.java Changed
    /src/main/.../utils/StatusChangeHelper.java Changed
    /src/main/.../web/RequisitionDtoBuilder.java Changed
    /src/.../utils/StatusChangeHelperTest.java Changed
    /src/.../web/RequisitionDtoBuilderTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against