OLMIS-3351: [performance] do not export unnecessary fields retrive all

Activity

FEOLMIS-2084 34

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 21m 13 Josh asked me to divide logic changes from performance ch...
    Reviewer - Complete 28m 2 Add changelog
    Reviewer - Complete 1h 19m 11 This was a big review, however I think I've added all my ...
    Total   3h 8m 34  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    Add changelog

    Add changelog

    Josh Zamor

    This was a big review, however I think I've added all my initial comments. Ne...

    This was a big review, however I think I've added all my initial comments. Next time lets use smaller reviews (where each on is focused on one particular change: 1 for the export, 1 for the buildBatch thing, etc)

    Paweł Gesek

    Josh Zamor I've went through this review and resolved most of your comments (...

    Josh Zamor I've went through this review and resolved most of your comments (expect one). Can you take a look at that one and let us know if you want to be involved in resolving it.

    Most of your comments are resolved through the new review that introduces the pattern you suggested, so lets continue there.

    /src/.../web/BaseWebIntegrationTest.java Changed 2
    /src/.../web/BatchRequisitionControllerIntegrationTest.java Changed
    /src/main/.../domain/Requisition.java Changed 4
    /src/main/.../domain/RequisitionLineItem.java Changed 21
    /src/.../utils/RequisitionExportHelper.java Changed
    /src/.../web/BaseRequisitionController.java Changed
    /src/.../web/BatchRequisitionController.java Changed 3
    /src/main/.../web/RequisitionDtoBuilder.java Changed 1
    /src/.../web/RequisitionDtoBuilderTest.java Changed
    /CHANGELOG.md Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against