OLMIS-3453: Added index in order_line_items fk

Activity
Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 2m 1 I think it could be used when POD is created. Currently w...
    Reviewer - Complete 7m 1 Josh Zamor Łukasz is out, does it answer your question?
    Reviewer - 66% reviewed 0m    
    Reviewer - Complete 16m 6 LGTM, thanks.
    Reviewer - 66% reviewed 4m    
    Reviewer - 33% reviewed 1m 1 I think Łukasz Lewczyński is confusnig the orderid with o...
    Total   30m 9  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Josh Zamor

    This is looking good. Left a comment on one.

    This is looking good. Left a comment on one.

    Josh Zamor

    Łukasz Lewczyński and Paweł Albecki: I lost this one for a bit as it wasn't p...

    Łukasz Lewczyński and Paweł Albecki: I lost this one for a bit as it wasn't put back into review after I marked it complete with unresolved comments the first pass. Please make sure you re-open it for review to ensure it shows up on my review dashboard. Thanks.

    Josh Zamor

    LGTM, thanks.

    LGTM, thanks.

    /src/.../migration/20171026100857964__create_index_on_order_file_columns_fk.sql Added
    Open in IDE #permalink
    /src/.../migration/20171026101428783__create_index_on_order_line_items_fk.sql Added
    Open in IDE #permalink
    /src/.../migration/20171026101430373__create_index_on_proof_of_deliveries_fk.sql Added
    Open in IDE #permalink
    /src/.../migration/20171026101431689__create_index_on_proof_of_delivery_line_items_fks.sql Added 6
    Open in IDE #permalink
    /src/.../migration/20171026101433045__create_index_on_status_changes_fk.sql Added
    Open in IDE #permalink
    /src/.../migration/20171026101434461__create_index_on_status_messages_fk.sql Added
    Open in IDE #permalink
    /src/.../migration/20171026101435933__create_index_on_template_parameters_fk.sql Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against