OLMIS-3351: add search by ids to /facilities endpoint

Activity

FEOLMIS-2064 35

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 22m 10 Josh Zamor Paweł Gesek Is it ok now?
    Reviewer - 79% reviewed 48m 2 uuuuu wiiiiii, that's a problem https://review.openlmis.o...
    Reviewer - Complete 1h 20m 18 Looks like all of my comments have been addressed. Thanks...
    Total   3h 30m 35  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    I understand what this is doing, but I don't see how this is connected to the...

    I understand what this is doing, but I don't see how this is connected to the ticket?

    Paweł Albecki

    I will use search facilities by multiple ids in requisition batch retrieve.

    I will use search facilities by multiple ids in requisition batch retrieve.

    Josh Zamor

    Think this one also needs a changelog entry as we added to the API.

    Think this one also needs a changelog entry as we added to the API.

    Josh Zamor

    Alright, think I've added my comments. Looking good.

    Alright, think I've added my comments. Looking good.

    Josh Zamor

    Looks like all of my comments have been addressed. Thanks for pushing it over...

    Looks like all of my comments have been addressed. Thanks for pushing it over the finish line!

    /src/.../repository/FacilityRepositoryIntegrationTest.java Changed
    /src/.../web/FacilityControllerIntegrationTest.java Changed
    /src/.../repository/FacilityRepository.java Changed
    /src/main/.../service/FacilityService.java Changed 10
    /src/main/.../referencedata/util/UuidUtil.java Changed 4
    /src/main/.../web/FacilityController.java Changed 3
    /src/main/resources/api-definition.yaml Changed 10
    /src/test/.../service/FacilityServiceTest.java Changed 3
    /CHANGELOG.md Changed
    /build.gradle Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against