OLMIS-3199: Added Database class

Activity

FEOLMIS-2031 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 17m 4 Nick Reid Mateusz Kwiatkowski I'm closing this review as ...
    Reviewer - Complete 19m 3 This is looking good // I do wonder if "database" is a cl...
    Reviewer - 0% reviewed      
    Reviewer - Complete 10m 5 Why are you calling all those objects 'docs'?
    Total   46m 12  
    #permalink

    Objectives

    These changes are made on a branch!
    The purpose of this review is to agree that the class introduced is going in the right direction.
    I'm aware that this lacks documentation .

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nick Reid

    This is looking good // I do wonder if "database" is a clear enough name – I ...

    This is looking good // I do wonder if "database" is a clear enough name – I kinda want to be super specific and call it "LocalDatabase"

    --> but if no one else has a strong opinion, lets just leave it

    Nikodem Graczewski

    Nick Reid Mateusz Kwiatkowski I'm closing this review as I have pushed the th...

    Nick Reid Mateusz Kwiatkowski I'm closing this review as I have pushed the this commit to master (with added JSDocs and refactored code).

    /src/openlmis-database/database.js Added 10
    Open in IDE #permalink
    /src/openlmis-database/database.spec.js Added
    Open in IDE #permalink
    /src/openlmis-database/openlmis-database.module.js Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against