OLMIS-2911: added 2 fields to jasper template parameter

Activity

FEOLMIS-1765 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 22m    
    Reviewer - Complete 11m 3 Looks good
    Reviewer - 0% reviewed      
    Total   34m 3  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Paweł Nawrocki

    Once this is resolved, please commit the same to report service.

    Once this is resolved, please commit the same to report service.

    Paweł Nawrocki

    Looks good

    Looks good

    /src/.../domain/JasperTemplateParameter.java Changed
    /src/.../dto/JasperTemplateParameterDto.java Changed
    /src/.../migration/20170731115053512__jasper_template_parameter_additional_columns.sql Added
    Open in IDE #permalink
    /src/.../schemas/jasperTemplateParameterDto.json Changed
    Open in IDE #permalink
    /src/report/report.factory.js Changed
    /src/report/report.service.js Changed
    /demo-data/requisition.template_parameters.json Changed
    /src/.../domain/JasperTemplateParameter.java Changed 1
    /src/.../dto/JasperTemplateParameterDto.java Changed
    /src/.../migration/20170728191010624__jasper_tempalte_parameter_aditional_columns.sql Added
    Open in IDE #permalink
    /src/.../schemas/jasperTemplateParameterDto.json Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time