OLMIS-2873: add framework for send notifications – tests

Activity

FEOLMIS-1751 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 12m 5 I guess IDEA i too dumb to move it itself
    Reviewer - Complete 28m 7 LGTM
    Total   40m 12  
    #permalink

    Objectives

    Work on notifier is in progress but I moved many code from requisition service as notifications framework. I made some improvements and added some tests so after review (which will probably result in more improvements) I will commit some improvements back to requisition service.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    /src/main/.../notifier/BaseNotifier.java Added
    Open in IDE #permalink
    /src/main/.../notifier/StockoutNotifier.java Added
    Open in IDE #permalink
    /src/main/.../service/BaseNotifier.java Deleted
    Open in IDE #permalink
    /src/main/.../service/NotificationService.java Changed
    /src/main/.../service/StockoutNotifier.java Deleted
    Open in IDE #permalink
    /src/main/resources/application.properties Changed
    /src/.../service/StockoutNotifierTest.java Added
    Open in IDE #permalink
    /src/.../referencedata/SupervisoryNodeReferenceDataServiceTest.java Added 5
    /src/.../service/NotificationServiceTest.java Added 3
    /src/.../service/StockoutNotifierTest.java Deleted 2
    Open in IDE #permalink
    /src/.../service/SupervisingUsersReferenceDataServiceTest.java Added
    Open in IDE #permalink
    /src/test/.../testutils/DummyPage.java Added
    Open in IDE #permalink
    /src/test/.../util/AuthServiceTest.java Added 1
    /src/test/.../util/RequestHelperTest.java Added
    Open in IDE #permalink
    /src/test/.../util/RequestParametersTest.java Added
    Open in IDE #permalink
    /build.gradle Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time