OLMIS-2817: added upload CCE catalog item page

Activity

FEOLMIS-1726 48

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 6h 24m 7 Nick Reid I've just add required to this input and everyt...
    Reviewer - Complete 40m 16 Why are those commented out?
    Reviewer - Complete 1h 25m 25 (4 defects) use `is-empty` to be more SMACSS-y??
    Total   8h 30m 48 (4 defects)  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Nikodem Graczewski

    That's a lot of code for restoring '}' https://review.openlmis.org/static/ql0...

    That's a lot of code for restoring '}'

    Nick Reid

    These improvements look good

    These improvements look good

    /src/admin-cce/admin-cce.module.js Deleted 5
    Open in IDE #permalink
    /src/admin-cce/admin-cce.routes.js Deleted 1
    Open in IDE #permalink
    /src/admin-cce/cce-upload.controller.js Deleted 1
    Open in IDE #permalink
    /src/admin-cce/cce-upload.controller.spec.js Deleted 1
    Open in IDE #permalink
    /src/admin-cce/cce-upload.html Deleted 3
    Open in IDE #permalink
    /src/admin-cce/messages_en.json Deleted 1
    Open in IDE #permalink
    /src/admin-cce-upload/admin-cce-upload.module.js Added
    Open in IDE #permalink
    /src/admin-cce-upload/admin-cce-upload.routes.js Added
    Open in IDE #permalink
    /src/admin-cce-upload/cce-upload.controller.js Added
    /src/admin-cce-upload/cce-upload.controller.spec.js Added
    /src/admin-cce-upload/cce-upload.html Added 2
    /src/admin-cce-upload/messages_en.json Added
    Open in IDE #permalink
    /src/cce/cce.controller.js Deleted
    Open in IDE #permalink
    /src/cce/cce.controller.spec.js Deleted
    Open in IDE #permalink
    /src/cce/cce.scss Deleted
    Open in IDE #permalink
    /src/cce-catalog-item/cce-catalog-item.module.js Added
    Open in IDE #permalink
    /src/cce-catalog-item/cce-catalog-item.service.js Added 3
    /src/cce-catalog-item/cce-catalog-item.service.spec.js Added 1
    /src/openlmis-upload/openlmis-upload.module.js Deleted
    Open in IDE #permalink
    /src/openlmis-upload/upload.directive.js Deleted
    Open in IDE #permalink
    /config.json Changed 2
    /docker-compose.yml Changed
    /src/common/buttons.scss Changed 1
    /src/openlmis-config/FormData.js Added
    Open in IDE #permalink
    /src/openlmis-file-upload/file-upload.html Added 2
    Open in IDE #permalink
    /src/openlmis-file-upload/file-upload.scss Added 6
    /src/openlmis-file-upload/messages_en.json Added
    /src/openlmis-file-upload/openlmis-file-upload.directive.js Added 7
    /src/openlmis-file-upload/openlmis-file-upload.directive.spec.js Added 1
    Open in IDE #permalink
    /src/openlmis-file-upload/openlmis-file-upload.module.js Added
    Open in IDE #permalink
    /src/openlmis-form/input-control-wrap.directive.js Changed 2
    /src/openlmis-upload/messages_en.json Deleted
    Open in IDE #permalink
    /src/openlmis-upload/openlmis-upload.module.js Deleted
    Open in IDE #permalink
    /src/openlmis-upload/upload.directive.js Deleted 5
    Open in IDE #permalink
    /src/openlmis-upload/upload.html Deleted
    Open in IDE #permalink
    /src/openlmis-upload/upload.scss Deleted 1
    Open in IDE #permalink
    /CHANGELOG.md Changed 1

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time