Create OpenLMIS CCE UI

Activity

FEOLMIS-1703 10

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 17m 4 Updated
    Reviewer - 0% reviewed      
    Reviewer - Complete 14m 6 LGTM
    Total   31m 10  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Paweł Nawrocki

    Nikodem Graczewski Mateusz Kwiatkowski I had to add those example classes for...

    Nikodem Graczewski Mateusz Kwiatkowski I had to add those example classes for cce module, since otherwise it wouldn't build (karma fails when there's no unit tests, kss fails when there's no documentation, etc.)

    Mateusz Kwiatkowski

    Maybe you could add cce-url.factory.js file?

    Maybe you could add cce-url.factory.js file?

    Mateusz Kwiatkowski

    Shouldn't we add this repo to refderence-ui?

    Shouldn't we add this repo to refderence-ui?

    Paweł Nawrocki

    Mateusz Kwiatkowski Updated
    /src/cce/cce-url.factory.js Added
    Open in IDE #permalink
    /src/cce/cce.controller.js Added
    Open in IDE #permalink
    /src/cce/cce.controller.spec.js Added
    Open in IDE #permalink
    /src/cce/cce.module.js Added
    /src/cce/cce.scss Added 2
    Open in IDE #permalink
    /src/cce/messages_en.json Added
    Open in IDE #permalink
    /src/openlmis-example/messages_en.json Deleted
    Open in IDE #permalink
    /src/openlmis-example/openlmis-example.html Deleted
    Open in IDE #permalink
    /src/openlmis-example/openlmis-example.module.js Deleted
    Open in IDE #permalink
    /src/openlmis-example/openlmis-example.routes.js Deleted
    Open in IDE #permalink
    /Dockerfile Changed
    /Gruntfile.js Added
    Open in IDE #permalink
    /README.md Changed
    Open in IDE #permalink
    /bower.json Changed
    /build.sh Changed
    /config.json Changed
    /docker-compose.yml Changed
    /package.json Changed 2
    /version.properties Changed 1
    /docker-compose.yml Changed
    /package.json Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against