OLMIS-2609: Add Manage CCE right checks in the existing CRUD endpoints

Activity

FEOLMIS-1701 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 29m 5 I added
    Reviewer - 92% reviewed 17m 5 Test names invalid. Please apply fixes to whole file.
    Reviewer - Complete 20m 1 Maybe you should add some of these files to template-serv...
    Total   1h 6m 11  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mateusz Kwiatkowski

    Maybe you should add some of these files to template-service? i.e. AbstractEr...

    Maybe you should add some of these files to template-service? i.e. AbstractErrorHandling, GlobalErrorHandling, MessageService etc.

    Paweł Nawrocki

    By the way, it's always confusing to me why are there these two classes inste...

    By the way, it's always confusing to me why are there these two classes instead of one?

    Paweł Albecki

    I guess some servic error handling classes can extend AbstractErrorHandling a...

    I guess some servic error handling classes can extend AbstractErrorHandling and shouldn't GlobalErrorHandling

    Paweł Albecki

    I added

    I added

    /src/.../web/BaseWebIntegrationTest.java Changed
    /src/.../web/CatalogItemControllerIntegrationTest.java Changed 4
    /src/.../errorhandling/AbstractErrorHandling.java Added
    Open in IDE #permalink
    /src/.../errorhandling/GlobalErrorHandling.java Added
    Open in IDE #permalink
    /src/.../exception/PermissionMessageException.java Added
    Open in IDE #permalink
    /src/main/java/.../cce/i18n/MessageKeys.java Changed
    /src/main/.../cce/i18n/MessageService.java Added
    Open in IDE #permalink
    /src/.../referencedata/UserReferenceDataService.java Changed
    /src/main/.../service/PermissionService.java Added 2
    Open in IDE #permalink
    /src/main/.../web/CatalogItemController.java Changed
    /src/main/resources/messages_en.properties Changed
    /src/.../service/PermissionServiceTest.java Added 1
    /src/.../migration/20170710120137838__create_cce-manage_right.sql Added
    Open in IDE #permalink
    /src/.../errorhandling/AbstractErrorHandling.java Added
    Open in IDE #permalink
    /src/.../errorhandling/GlobalErrorHandling.java Added
    Open in IDE #permalink
    /src/.../exception/BaseMessageException.java Added
    Open in IDE #permalink
    /src/main/.../exception/NotFoundException.java Added
    Open in IDE #permalink
    /src/main/.../template/i18n/MessageKeys.java Added
    Open in IDE #permalink
    /src/main/.../i18n/MessageService.java
    /src/main/java/.../template/util/Message.java Added
    Open in IDE #permalink
    /src/main/.../web/WidgetController.java Changed
    /src/main/resources/messages_en.properties Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against