OLMIS-1933 Change infrastructure/dev images from latest to version number

Activity

FEOLMIS-1278 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 12m    
    Reviewer - Complete 2m 1 Looks okay to me. I don't understand all of the implicati...
    Reviewer - Complete 5m 1 It's to make everything a tedious workflow. No, it's so ...
    Total   18m 2  
    #permalink

    Objectives

    Review changes to postgres, docker-dev, dev-ui, nginx, rsyslog, service-base.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    brandon

    Looks okay to me. I don't understand all of the implications for versioning, ...

    Looks okay to me. I don't understand all of the implications for versioning, but Josh should grok it all.

    Josh Zamor

    It's to make everything a tedious workflow. No, it's so that we can go back ...

    It's to make everything a tedious workflow.

    No, it's so that we can go back in time, and build 3.0, when we're working on 3.5 with JDK 9, and there is a dev image and all the other crap out there that's published to docker hub with JDK8 (and all the other tools)

    LGTM

    /Dockerfile Changed
    /docker-compose.builder.yml Changed
    /docker-compose.erd-generation.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed
    /docker-compose.referencedata.yml Changed
    /docker-compose.requisition.yml Changed
    /docker-compose.stockmanagment.yml Changed
    /docker-compose.yml Changed
    /deployment/shared/pull_images.sh Changed
    /deployment/test_env/docker-compose.yml Changed
    /deployment/uat_env/docker-compose.yml Changed
    /Dockerfile Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.yml Changed
    Open in IDE #permalink
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /ref-distro-example-docker-compose.yml Changed
    Open in IDE #permalink
    /Dockerfile Changed
    /docker-compose.builder.yml Changed
    /docker-compose.erd-generation.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed
    /Dockerfile Changed
    /docker-compose.builder.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed
    /README.md Changed
    /docker-compose.yml Changed
    /docker-compose.yml Changed
    /Dockerfile Changed
    /docker-compose.builder.yml Changed
    /docker-compose.erd-generation.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed
    /Dockerfile Changed
    /docker-compose.builder.yml Changed
    /docker-compose.erd-generation.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed
    /Dockerfile-dev Changed
    /docker-compose.builder.yml Changed
    /docker-compose.yml Changed
    /docker-compose.override.yml Changed
    Open in IDE #permalink
    /docker-compose.yml Changed
    Open in IDE #permalink
    /local-manual-api-test/docker-compose.yml Changed
    /docker-compose.builder.yml Changed
    /docker-compose.erd-generation.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed
    /docker-compose.builder.yml Changed
    Open in IDE #permalink
    /docker-compose.yml Changed
    Open in IDE #permalink
    /Dockerfile Changed
    /docker-compose.builder.yml Changed
    /docker-compose.override.yml Changed
    /docker-compose.yml Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against