OLMIS-1939: Added environment vars in README files

Activity

FEOLMIS-1261 33

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 19m 14 Made it blank
    Reviewer - Complete 7m 4 All fixed. THanks!
    Reviewer - 30% reviewed 9m 4 Yes, I think it makes most sense to place in fulfillment ...
    Reviewer - Complete 12m 5 My comments are all resolved. LGTM.
    Reviewer - Complete 13m 6 Just have minor issues; LGTM.
    Total   1h 2m 33  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Sebastian Brudziński

    it looks like several variables havent been documented. Any reason for skippi...

    it looks like several variables havent been documented. Any reason for skipping them? (all DB, FTP and Transifex related ones)

    Paweł Gesek

    Well FTP belongs to an external image we are using for tests, but I guess I c...

    Well FTP belongs to an external image we are using for tests, but I guess I can include it (in fulfillment?).
    Guess I missed the db - i'll add it to the template readme.
    Transifex variables? What Transifex variables?

    Chongsun Ahn

    You'll notice that the .env files in the private openlmis-config repo has Tra...

    You'll notice that the .env files in the private openlmis-config repo has Transifex variables. This is to sync with Transifex projects during the CI process.

    Sebastian Brudziński

    Yes, I think it makes most sense to place in fulfillment since it's the only ...

    Yes, I think it makes most sense to place in fulfillment since it's the only service using that atm.

    Chongsun Ahn

    Just have minor issues; LGTM.

    Just have minor issues; LGTM.

    Paweł Gesek

    I've added database, transifex and FTP vars

    I've added database, transifex and FTP vars

    Josh Zamor

    Added a couple notes/questions. Otherwise looks good. Thanks.

    Added a couple notes/questions. Otherwise looks good. Thanks.

    Josh Zamor

    My comments are all resolved. LGTM.

    My comments are all resolved. LGTM.

    brandon

    All fixed. THanks!

    All fixed. THanks!

    /README.md Changed 3
    /.env Changed 4
    /README.md Changed 3
    /src/main/resources/application.properties Changed
    /README.md Changed 5
    /README.md Changed
    /README.md Changed
    /README.md Changed
    /README.md Changed 9

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against