OLMIS-1686: Add checkstyle check for copyright header

Activity

FEOLMIS-1192 11

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 25m 6 Done!
    Reviewer - Complete 2m 1 Yes, this looks right to me as well.
    Reviewer - Complete 9m 4 LGTM
    Reviewer - 0% reviewed      
    Total   35m 11  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Paweł Gesek

    I am not adding commits that add the actual headers - let's not clutter this ...

    I am not adding commits that add the actual headers - let's not clutter this review with that. Will add reviewers once we have all repos here

    brandon

    Yes, this looks right to me as well.

    Yes, this looks right to me as well.

    /config/checkstyle/checkstyle.xml Changed 8
    Open in IDE #permalink
    Repository openlmims-example-extension does not exist
    /src/main/.../extension/AmcOrderQuantity.java Changed
    Open in IDE #permalink
    Repository openlmims-example-extension does not exist
    /LICENSE-HEADER Added
    Open in IDE #permalink
    Repository openlmims-example-extension does not exist
    /config/checkstyle/checkstyle.xml Changed
    /LICENSE-HEADER Added
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    Open in IDE #permalink
    /LICENSE-HEADER Added
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    /LICENSE-HEADER Added
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    /LICENSE-HEADER Added
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    /config/checkstyle/checkstyle.xml Changed
    /config/checkstyle/checkstyle.xml Changed
    Open in IDE #permalink
    /LICENSE-HEADER Added
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    /LICENSE-HEADER Added
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    Open in IDE #permalink
    /LICENSE-HEADER Added
    Open in IDE #permalink
    /config/checkstyle/checkstyle.xml Changed
    /LICENSE-HEADER Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against