OLMIS-970: Move the date converter class to shared library

Activity

FEOLMIS-1190 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1m 1 I had to add this line @EntityScan(basePackageClasses = B...
    Reviewer - Complete 6m 2 LGTM
    Total   8m 3  
    #permalink

    Objectives

    The converter class will be used by many independent services. It should be placed in the shared library for all of them to use.

    Acceptance:

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Łukasz Lewczyński

    I had to add this line @EntityScan(basePackageClasses = BaseEntity.class, bas...

    I had to add this line

    @EntityScan(basePackageClasses = BaseEntity.class, basePackages = "org.openlmis.util.converter")

    because hibernate did not see converters from our library.

    Sebastian Brudziński

    Ah so that's why all the Converter annotations are gone... I was wondering wh...

    Ah so that's why all the Converter annotations are gone... I was wondering where the hell did they go and why it still works.

    /src/main/.../template/Application.java Changed
    Open in IDE #permalink
    Repository Service_Template does not exist
    /src/.../domain/ZonedDateTimeAttributeConverter.java Deleted
    Open in IDE #permalink
    /src/main/.../openlmis/auth/Application.java Changed
    /src/.../convert/LocalDatePersistenceConverter.java Deleted
    Open in IDE #permalink
    /src/.../convert/ZonedDateTimeAttributeConverter.java Deleted
    Open in IDE #permalink
    /src/main/.../fulfillment/Application.java Changed
    /src/main/.../domain/Facility.java Changed
    /src/main/.../domain/ProcessingPeriod.java Changed
    /src/main/.../domain/SupportedProgram.java Changed
    /src/.../domain/ZonedDateTimeAttributeConverter.java Deleted
    Open in IDE #permalink
    /src/.../util/LocalDatePersistenceConverter.java Deleted
    Open in IDE #permalink
    /src/.../util/LocalDateTimePersistenceConverter.java Deleted
    Open in IDE #permalink
    /src/main/.../referencedata/Application.java Changed
    /src/.../domain/ZonedDateTimeAttributeConverter.java Deleted
    Open in IDE #permalink
    /src/main/.../org/openlmis/Application.java Changed
    /src/.../domain/ZonedDateTimeAttributeConverterTest.java Deleted
    Open in IDE #permalink
    /src/.../converter/LocalDateAttributeConverter.java Added
    Open in IDE #permalink
    /src/.../converter/ZonedDateTimeAttributeConverter.java Added
    Open in IDE #permalink
    /src/.../converter/ZonedDateTimeAttributeConverterTest.java Added
    Open in IDE #permalink
    /build.gradle Changed
    /src/main/.../template/Application.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against