Clone
 

jakub hopen <jhopen@soldevelo.com> in openlmis-fulfillment

OLMIS-1662 changed comment & added validation in UT in Permission Service

OLMIS-1662 Added comment in unit test about using service level tokens.

OLMIS-1662: Added missing integration tests

renamed throwIfMissingPermission method to checkPermission in PermissionService,

moved right check in endpoints to be first thing called.

OLMIS-1662 created right Manage SystemSettings

added rightcheck for SYSTEM_SETTINGS_MANAGE to :

api/configurationSettings,

api/orderFileTemplates,

api/orderNumberConfigurations,

api/proofOfDeliveryTemplates,

api/transferProperties

updated raml,

fixed unit tests,

added service level tokec check to listed endpoints.

    • -0
    • +52
    /src/main/resources/api-definition.yaml
OLMIS-1764 Fulfillment service starts using flyway

removed bootstrap.sql

removed schema.sql

added demo_sql_footer

added demo_sql_header

added initial schema and bootstrap sql files

modified application.java

modified demo_seed.sh

modified build.gradle

    • -0
    • +4
    /demo-data/demo_sql_footer.txt
    • -0
    • +6
    /demo-data/demo_sql_header.txt
    • -0
    • +0
    /src/main/resources/db/starter/.gitignore
OLMIS-1747 Changed right name FULFILLMENT_TRANSFER_ORDER to ORDERS_TRANSFER

OLMIS-1757 Added @Transcational to controllers

FulfillmentException now extends RuntimeException,

rmoved throws from method declarations.

  1. … 6 more files in changeset.
OLMIS-1628 removed useless annotations

removed @Convert annotation from Order and ProofOfDelivery domain classes.

OLMIS-1628 Update dates in Fulfillment to match timezone design

changed LocalDate to ZonedDateTime in ProofOfDelivery and related classes,

changed LocalDate to ZonedDateTime in Order and related classes,

created ZonedDateTImeAttributeConverter,

fixed integration tests,

removed LocalDateTimePersistanceConverter.

OLMIS-1690 changef field names

changed field name productCategoryDisplayName to orderableCategoryDisplayName,

changed productCategoryDisplayOrder to orderableCategoryDisplayOrder.

OLMIS-1690 restored changed field name

changed orderableDisplayCategoryDisplayName to productCategoryDisplayName

changed orderableDisplayCategoryDisplayOrder to productCategoryDisplayOrder in ProgramOrderableDto.

OLMIS-1690 refactored class names

renamed OrderableDto to OrderableDto,

renamed ProgramProductDto to ProgramOrderableDto,

renamed OrderableProductReferenceData to OrderableReferenceDataService,

changed fields names according to renaming,

updated fields names in demo-data,

updated schemas and raml.

    • -8
    • +8
    /demo-data/fulfillment.order_line_items.json
  1. … 10 more files in changeset.
OLMIS-1690 refactored class names

renamed OrderableDto to OrderableDto,

renamed ProgramProductDto to ProgramOrderableDto,

renamed OrderableProductReferenceData to OrderableReferenceDataService,

changed fields names according to renaming,

updated fields names in demo-data,

updated schemas and raml.

    • -8
    • +8
    /demo-data/fulfillment.order_line_items.json
  1. … 10 more files in changeset.
OLMIS-1582 fixed typo error in raml

OLMIS-1582 fixed incerrect type in raml

OLMIS-1582 renamed enum and added setter

renamed enum RequisitionStatus to ExternalStatus,

added setter in Order.Export interface.

OLMIS-1582 added StatusMessage entity

added statusMessage field to Order,

added RequisitionStatus enum,

modified raml.

    • -0
    • +12
    /src/main/resources/schemas/orderDto.json
    • -0
    • +31
    /src/main/resources/schemas/statusMessageDto.json
OLMIS-1499 changed error message key to fulfillment.error.order.invalid-status

OLMIS-1499 Added IT for OrderController

added 404 response code for finalize order endpoint and IT for it,

added value to messages_en.properties,

changed parameter name in InvalidOrderStatusException,

changed return type for endpoint in OrderController.

    • -0
    • +1
    /src/main/resources/api-definition.yaml
OLMIS-1499 Added IT for http code responses from endpoints

added InvalidOrderStatusException,

added IT for OrderFileTemplateController,

modified raml,

added missing field in export and newInstance for OrderFileColumn.

    • -3
    • +20
    /src/main/resources/api-definition.yaml
Removed json annotations from domain classes and restored needed annotations

modified IT to use dto objects.

Removed useless annotations from Order and ProofOfDelivery classes

OLMIS-1427 moved dto classes to web/util catalog

changed newInstance method signatures,

renamed left newDomainName methods,

added missing newInstance method.

  1. … 20 more files in changeset.
OLMIS-1427 removed Builder classes and unnecessary code, modified dto and domain classes

  1. … 13 more files in changeset.
OLMIS-1427 changed endpoints to use DTO to communicate

Added DTO classes,

added Import and Export interfaces to domain calsses,

added Builders and DtoBuilders classes,

modified endpoints to send and receive Dto objects,

modified RAML and schemas.

    • -0
    • +101
    /src/main/java/org/openlmis/fulfillment/dto/OrderDto.java
  1. … 39 more files in changeset.
OLMIS-1385 changed methods names in unit test

OLMIS-1385 endpoint checks right to convert order for warehouse and not facility and program

updated unit tests

OLMIS-1385 fised UT and moved ResultDto to model catalog.

OLMIS-1385 removed facility validation

there is no need for validation of facility so it has been removed,

removed unnecessary files,

fixed some Sonar errors,

createOrder endpoint returns Order object,

fixed UT and IT,

removed supervisoryNodeId from Order since there is no need for it,

fixed raml schema.

    • -4
    • +0
    /src/main/resources/api-definition.yaml
    • -4
    • +0
    /src/main/resources/schemas/order.json
OLMIS-1385 removed useless exception throws in createOrder signature