openlmis-requisition-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Yep

Yep

are you sure this should be lower case string?

are you sure this should be lower case string?

Then that will be the point when we should make it global.

Then that will be the point when we should make it global.

I feel like this soon will be copy pasted couple of times though.

I feel like this soon will be copy pasted couple of times though.

It is only used in one place at the moment so we don't really need it globally (YAGNI).

It is only used in one place at the moment so we don't really need it globally (YAGNI).

I think that we should assign those values to this property to avoid memory leaks?

I think that we should assign those values to this property to avoid memory leaks?

can we maybe have this globally

can we maybe have this globally

Yep

Yep

are those messages available?

are those messages available?

I think you need to update this description and add return annotation

I think you need to update this description and add return annotation

Definitely not! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif Forgot about them!

Definitely not! Forgot about them!

this.this? Is that intentional?

this.this? Is that intentional?

It's safe to look at this file as completely new, to be honest.

It's safe to look at this file as completely new, to be honest.

same here

same here

same here

same here

We're actually adding them here.

We're actually adding them here.

These methods will work as intended (thanks to the .andCallThrough) so there is no need to multiply the build methods for spy and non-spy ones (YAGNI).

These methods will work as intended (thanks to the .andCallThrough) so there is no need to multiply the build methods for spy and non-spy ones (YAGNI).

More like each time I need a spy on a method.

More like each time I need a spy on a method.

too many changes so it is hard to read https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/sad.gif

too many changes so it is hard to read

same here

same here