openlmis-ref-distro

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5989: Updated info about building documentation
OLMIS-5989: Updated info about building documentation
I was added intentionally because it can be moved to another directory or updated and the link would be invalid but I can change it to master if you really want.

I was added intentionally because it can be moved to another directory or updated and the link would be invalid but I can change it to master if you really want.

Is it okay that we use commit id (oefdc844...) instead of master branch in the URL?

Is it okay that we use commit id (oefdc844...) instead of master branch in the URL?

Worth linking to the Object Reference Expander as it does all of the job and not all the services have it implemented yet.

Worth linking to the Object Reference Expander as it does all of the job and not all the services have it implemented yet.

are -> and?

are -> and?

the whole representation while a basic representation is enough.

the whole representation while a basic representation is enough.

No blank space after dot.

No blank space after dot.

OLMIS-6021: Updated performance tips
OLMIS-6021: Updated performance tips
Yes

Yes

the UUID of the ...

the UUID of the ...

Is the comment removed?

Is the comment removed?

I agree. The duplicated files seem to have slight differences and are most likely coming from two different branches. Mateusz Kwiatkowski, could you fix up the review?

I agree. The duplicated files seem to have slight differences and are most likely coming from two different branches. Mateusz Kwiatkowski, could you fix up the review?

This is already done, check it out here: https://review.openlmis.org/cru/#FEOLMIS-3601CFR-48720

This is already done, check it out here: https://review.openlmis.org/cru/#FEOLMIS-3601CFR-48720

duplication of files make that the review is hard to read

duplication of files make that the review is hard to read

missing changelog

missing changelog

do we have ticket for that?

do we have ticket for that?

OLMIS-4373: removed filterBy option from requisitionsForConvert endpoint
OLMIS-4373: removed filterBy option from requisitionsForConvert endpoint
OLMIS-5977, update forum and developer guide links
OLMIS-5977, update forum and developer guide links
I saw that there are more images that use openlmis/awscli image so there is definitely a need of versioning.

I saw that there are more images that use openlmis/awscli image so there is definitely a need of versioning.

Looks good. It might take the "single responsibility" principal a bit far (as in I could see one image for starting and stopping, or simply passing commands to the awscli image), however it looks f...

Looks good. It might take the "single responsibility" principal a bit far (as in I could see one image for starting and stopping, or simply passing commands to the awscli image), however it looks fully capable.

One aspect here that's a bit lacking is that if we're going to be building images off of the awscli image, then we should be versioning the awscli image. Without that versioning we will get to a house of cards scenario eventually, however this for now feels quite minor for this usage. Something to keep in mind if we take this further.