openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6031: added performance tests for supply lines
OLMIS-6031: added performance tests for supply lines
OLMIS-3395: restored FTAP query
OLMIS-3395: restored FTAP query
Shouldn't it be named "shouldThrowBadRequest..."?

Shouldn't it be named "shouldThrowBadRequest..."?

Sure, I'll do that.

Sure, I'll do that.

and if the facility does not exist then the endpoint will return 404?

and if the facility does not exist then the endpoint will return 404?

Because we are checking this in repository layer, should I mock repository here to throw a certain exception and check if it is coming through?

Because we are checking this in repository layer, should I mock repository here to throw a certain exception and check if it is coming through?

this was moved to repository layer together with getting facility type id

this was moved to repository layer together with getting facility type id

it should be false

it should be false

I think we should still check if a facility exists

I think we should still check if a facility exists

why removed?

why removed?

OLMIS-4291: moved getting facility type id based on facility id to repository layer
OLMIS-4291: moved getting facility type id based on facility id to repository layer
I think that there is changelog for this ticket already in breaking changes section

I think that there is changelog for this ticket already in breaking changes section

Yes, changelog was added earlier.

Yes, changelog was added earlier.

This is a breaking change. Did we mention that in the changelog?

This is a breaking change. Did we mention that in the changelog?

What about changelog? I know that there were a lot of changes related to the ticket so if the changelog was added earlier or will be added later then I am ok

What about changelog? I know that there were a lot of changes related to the ticket so if the changelog was added earlier or will be added later then I am ok

OLMIS-3773: Removed fetch and changed return type to BasicFacilityDto
OLMIS-3773: Removed fetch and changed return type to BasicFacilityDto