openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
both fields make sense for me

both fields make sense for me

I think there was a reason why we decided to call this property as entries but I don't remember. I am okay with changing it to subscriptions but I would wait for Chongsun Ahn response

I think there was a reason why we decided to call this property as entries but I don't remember. I am okay with changing it to subscriptions but I would wait for Chongsun Ahn response

I would say if a request has null or it is not set then backend should treat it as an empty list.

I would say if a request has null or it is not set then backend should treat it as an empty list.

Łukasz Lewczyński CC Chongsun Ahn The entries seem pretty generic... I'm having trouble grasping what they are actually representing. The only name for them I found at one of the eLMIS screenshot i...

Łukasz Lewczyński
CC Chongsun Ahn
The entries seem pretty generic... I'm having trouble grasping what they are actually representing. The only name for them I found at one of the eLMIS screenshot is "Subscription", but I'm not sure about that. Perhaps a simple "Assignment"? Anyway, we should definitely rename it to the picked name so the naming is ubiquitous.

In eLMIS the Supply Partner also had Name and Code, should we add them Chongsun Ahn?

In eLMIS the Supply Partner also had Name and Code, should we add them Chongsun Ahn?

Same for the PUT below.

Same for the PUT below.

Or the token might be invalid. Same for others below.

Or the token might be invalid. Same for others below.

Technically a 400 is a bad request, so it might not simply be the query parameters that has an issue. Same for others below.

Technically a 400 is a bad request, so it might not simply be the query parameters that has an issue. Same for others below.

Why not a page?

Why not a page?

I think we should support that there may be a supply partner, but it may at any point not have any entries. All entries might be removed while configuring, or when first created, etc.

I think we should support that there may be a supply partner, but it may at any point not have any entries. All entries might be removed while configuring, or when first created, etc.

how about adding info for 404 error?

how about adding info for 404 error?

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

I think that this should say that you are not authorized to get this info

OK, great! but where is the info on fisheye that will tell me from which branch are those changes?

OK, great! but where is the info on fisheye that will tell me from which branch are those changes?

with entries as null there are no required fields in this model. Not sure if there is a sense to create a supply partner without entries (cc: Chongsun Ahn)

with entries as null there are no required fields in this model. Not sure if there is a sense to create a supply partner without entries (cc: Chongsun Ahn)

those changes are on branch https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

those changes are on branch

I'm not sure if we should change already existing endpoint definition before changes are introduced, this may be misleading.

I'm not sure if we should change already existing endpoint definition before changes are introduced, this may be misleading.

Can you add list of required entries?

Can you add list of required entries?

should this be null or rather empty list?

should this be null or rather empty list?

OLMIS-5137: Added RAML and JSON schema for supply partner resource
OLMIS-5137: Added RAML and JSON schema for supply partner resource
from the ticket: Will need to figure out the "reference list" of facilities to be able to assign to this entry (facilities that support the program and is under the original supervisory node?) Thi...

from the ticket: Will need to figure out the "reference list" of facilities to be able to assign to this entry (facilities that support the program and is under the original supervisory node?)

This endpoint is under /supervisoryNodes/{id}/

standard create, read (single or page) and update operations (no delete endpoint!) *audit log endpoint - not sure if needed
  • standard create, read (single or page) and update operations (no delete endpoint!)
  • audit log endpoint - not sure if needed
from the ticket: [...] A supply partner will have zero or more entries [...]

from the ticket: [...] A supply partner will have zero or more entries [...]

from the ticket: [...] each entry having a program, a supervisory node, and a list of facilities and a list of products.

from the ticket: [...] each entry having a program, a supervisory node, and a list of facilities and a list of products.