openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Then we don't need validation after updating processing period, please remove it if possible.

Then we don't need validation after updating processing period, please remove it if possible.

You should add this commit to this review then so reviewers can see those changes.

You should add this commit to this review then so reviewers can see those changes.

Hi Mateusz Kwiatkowski I added this lines of validation above since the error need to be handled(captured) before updating the processing period.

Hi Mateusz Kwiatkowski I added this lines of validation above since the error need to be handled(captured) before updating the processing period.

Yeah i have already added this message and committed in reference-data repository(541d497270d1e6efe17f93606209af6aa2252e1e). Thanks

Yeah i have already added this message and committed in reference-data repository(541d497270d1e6efe17f93606209af6aa2252e1e). Thanks

I don't get why we are doing this here? I see that a couple of lines below we are doing validation so this is redundant

I don't get why we are doing this here? I see that a couple of lines below we are doing validation so this is redundant

I would say that for user we should say something like processing schedule is required

I would say that for user we should say something like processing schedule is required

OLMIS-4948 - Fix Internal Server Error by providing a clear response message
OLMIS-4948 - Fix Internal Server Error by providing a clear response message
I'm not sure if I understand. Do you mean openlmis-demo-data? I don't see the compose file there... only Dockerfile and I've updated it based on openlmis-demo-data Dockerfile.

I'm not sure if I understand. Do you mean openlmis-demo-data? I don't see the compose file there... only Dockerfile and I've updated it based on openlmis-demo-data Dockerfile.

We should also have an annotation on the right assignment class to mark this unique constraint and to have hibernate validate it with the database

We should also have an annotation on the right assignment class to mark this unique constraint and to have hibernate validate it with the database

Done

Done

Done

Done

Done

Done

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

This should not be changed.

This should not be changed.

We will also need: *unique constraint on RightAssignment *migration to remove dupes

We will also need:

  • unique constraint on RightAssignment
  • migration to remove dupes
It's hard to use Set in all places here as JdbcTemplate class supports only List interface, I will change it at least before inserting changes into database.

It's hard to use Set in all places here as JdbcTemplate class supports only List interface, I will change it at least before inserting changes into database.

As discussed, set must be used across this class to properly prevent duplicates.

As discussed, set must be used across this class to properly prevent duplicates.

We will need to add supervisoryNodeId to the equals method of the RightAssignmentDto, or we will miss assignments for the same program but different SNs after this change to set.

We will need to add supervisoryNodeId to the equals method of the RightAssignmentDto, or we will miss assignments for the same program but different SNs after this change to set.

OLMIS-5467: Added script to wait for postgres
OLMIS-5467: Added script to wait for postgres
OLMIS-5666: fixed problem with duplicated right assignments
OLMIS-5666: fixed problem with duplicated right assignments