openlmis-deployment

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Yes

Yes

the UUID of the ...

the UUID of the ...

Is the comment removed?

Is the comment removed?

I agree. The duplicated files seem to have slight differences and are most likely coming from two different branches. Mateusz Kwiatkowski, could you fix up the review?

I agree. The duplicated files seem to have slight differences and are most likely coming from two different branches. Mateusz Kwiatkowski, could you fix up the review?

This is already done, check it out here: https://review.openlmis.org/cru/#FEOLMIS-3601CFR-48720

This is already done, check it out here: https://review.openlmis.org/cru/#FEOLMIS-3601CFR-48720

duplication of files make that the review is hard to read

duplication of files make that the review is hard to read

missing changelog

missing changelog

do we have ticket for that?

do we have ticket for that?

OLMIS-4373: removed filterBy option from requisitionsForConvert endpoint
OLMIS-4373: removed filterBy option from requisitionsForConvert endpoint
we only adjust the service so it should be treated as a patch change.

we only adjust the service so it should be treated as a patch change.

we only adjust the service so it should be treated as a patch change.

we only adjust the service so it should be treated as a patch change.

As discussed, this introduces a change of the contract for the search endpoint, so the version should be bumped to 13.0.0

As discussed, this introduces a change of the contract for the search endpoint, so the version should be bumped to 13.0.0

Are there more than 2 facilities created and saved in the database? If not, this "findByIds" may as well always return all facilities and this test passes.

Are there more than 2 facilities created and saved in the database? If not, this "findByIds" may as well always return all facilities and this test passes.

I think we could add sorted here

I think we could add sorted here

Where we use this? I mean the method has been changed but I don't see usage of it in the review

Where we use this? I mean the method has been changed but I don't see usage of it in the review

missing changelogs in all services. Because we change response structure don't forget to update service version (if needed)

missing changelogs in all services. Because we change response structure don't forget to update service version (if needed)

OLMIS-3773: Updated facilities search by ids to return page instead of array
OLMIS-3773: Updated facilities search by ids to return page instead of array
I had to put it before export calls because we are setting DOCKER_HOST there which was breaking this part due to server beeing down

I had to put it before export calls because we are setting DOCKER_HOST there which was breaking this part due to server beeing down

OLMIS-5728: added starting instance step to functional test deploy script
OLMIS-5728: added starting instance step to functional test deploy script
Also congrats on using Terraform for the first time.

Also congrats on using Terraform for the first time.

Looks good, thanks.

Looks good, thanks.