openlmis-stockmanagement-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bumped version to 2.0.2-SNAPSHOT

2.0.2-RC2 release

Bumped version to 2.0.2-SNAPSHOT

2.0.2-RC1 release

OLMIS-5354 Update referencedata-ui to 5.5.0-SNAPSHOT

Done

Done

OLMIS-5586: added test for grouping items by category

Not really, this list will only change if someone adds the product to draft, I was thinking of running this filter after adding a new product but I wasn't sure if I was covering all cases so this a...

Not really, this list will only change if someone adds the product to draft, I was thinking of running this filter after adding a new product but I wasn't sure if I was covering all cases so this approach is safer.

We should test this.

We should test this.

This might prove to be non-performant. Is there any way we could avoid using a watch here?

This might prove to be non-performant. Is there any way we could avoid using a watch here?

No changelog needed as it was introduced after the last release.

No changelog needed as it was introduced after the last release.

OLMIS-5586: fixed problem with grouping line items on physical inventory screen
OLMIS-5586: fixed problem with grouping line items on physical inventory screen
OLMIS-5586: fixed problem with grouping line items on physical inventory screen

We want to make sure that both boolean true and String 'true' pass this.

We want to make sure that both boolean true and String 'true' pass this.

OLMIS-5415: Fixed broken test

and why this is not a new String()?

and why this is not a new String()?

Good point, I forgot about removing products on this screen, resolving

Good point, I forgot about removing products on this screen, resolving

Why do we map boolean to String?

Why do we map boolean to String?

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

OLMIS-5438: code review comments

We're not adding JSDocs for them. They wouldn't really give us much.

We're not adding JSDocs for them. They wouldn't really give us much.

Should this constructor have doc?

Should this constructor have doc?

how about some doc?

how about some doc?

Move this out of the inject into the beforeEach function.

Move this out of the inject into the beforeEach function.