openlmis-stockmanagement-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
We want to make sure that both boolean true and String 'true' pass this.

We want to make sure that both boolean true and String 'true' pass this.

OLMIS-5415: Fixed broken test

and why this is not a new String()?

and why this is not a new String()?

Good point, I forgot about removing products on this screen, resolving

Good point, I forgot about removing products on this screen, resolving

Why do we map boolean to String?

Why do we map boolean to String?

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

OLMIS-5438: code review comments

We're not adding JSDocs for them. They wouldn't really give us much.

We're not adding JSDocs for them. They wouldn't really give us much.

Should this constructor have doc?

Should this constructor have doc?

how about some doc?

how about some doc?

Move this out of the inject into the beforeEach function.

Move this out of the inject into the beforeEach function.

1. I don't think this parameter is Integer type. rather a String type 2. this should be @param 3. add @return below with type Array 4. fix indentation as in other jsdocs so descriptions and paramet...

1. I don't think this parameter is Integer type. rather a String type
2. this should be @param
3. add @return below with type Array
4. fix indentation as in other jsdocs so descriptions and parameter names are aligned

This should be a DataBuilder so it can be reused.

This should be a DataBuilder so it can be reused.

I think that maybe you should do filtering (grouping) on entering the screen (i.e. in routes file) so you don't have to use memoize here

I think that maybe you should do filtering (grouping) on entering the screen (i.e. in routes file) so you don't have to use memoize here

please you remove '_' from this parameter name

please you remove '_' from this parameter name

OLMIS-5415: Disabled edit of some fields for externally managed facilities
OLMIS-5415: Disabled edit of some fields for externally managed facilities
OLMIS-5438 Categorize orderables under correct product categories
OLMIS-5438 Categorize orderables under correct product categories
OLMIS-5438 Display Products within the Product Categories on the Physical Inventory

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. T...

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. The change we're introducing here is locking dev-ui dependencies, which are no longer fetched to the node_modules in the root directory, but instead, are fetched into node_modules/dev-ui/node_modules. What we're doing is moving them to the node_modules directory so they are available to the module that is relying on dev-ui, lack of them there would break the build process because of missing dependencies. For yarn.lock we're basically copying the one generated in the .tmp directory, which is where we're firing yarn up during the build process. If you have any concern, please let me know.

These changes are virtually impossible to review in-depth.

These changes are virtually impossible to review in-depth.

https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204

https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46198

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46198