openlmis-requisition

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5795: Fixed a bug with calculated quantity isa being ignored when calculated quantity column is...
OLMIS-5795: Fixed a bug with calculated quantity isa being ignored when calculated quantity column is...
I guess these are not buttons but modals?

I guess these are not buttons but modals?

I'm not sure if I understand. Do you mean openlmis-demo-data? I don't see the compose file there... only Dockerfile and I've updated it based on openlmis-demo-data Dockerfile.

I'm not sure if I understand. Do you mean openlmis-demo-data? I don't see the compose file there... only Dockerfile and I've updated it based on openlmis-demo-data Dockerfile.

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

This should not be changed.

This should not be changed.

These should be separate instances of the ConfirmationModal.

These should be separate instances of the ConfirmationModal.

Could this be renamed to buttonLabel?

Could this be renamed to buttonLabel?

Rename path to selector.

Rename path to selector.

OLMIS-5467: Added script to wait for postgres
OLMIS-5467: Added script to wait for postgres
We can always update the button class to allow passing selector

We can always update the button class to allow passing selector

+1

+1

I would say that ConfimationModal should be used in ViewRequsitionPage, we should just pass messages to this new class. Make confirmation modal as button etc. is done in components directory.

I would say that ConfimationModal should be used in ViewRequsitionPage, we should just pass messages to this new class. Make confirmation modal as button etc. is done in components directory.

I'm not sure if it's possible, because then we'll get two buttons - one from the toolbar and second one from confirmation modal.

I'm not sure if it's possible, because then we'll get two buttons - one from the toolbar and second one from confirmation modal.

Please, use the button class here.

Please, use the button class here.

Definitely. I would also create a class representing a confirmation modal.

Definitely. I would also create a class representing a confirmation modal.

It could be in the confirmAuthorize method

It could be in the confirmAuthorize method

Could this be given instead of being steps?

Could this be given instead of being steps?

hmm maybe this should be moved to ViewRequisitionPage? Łukasz Lewczyński Nikodem Graczewski

hmm maybe this should be moved to ViewRequisitionPage?
Łukasz Lewczyński Nikodem Graczewski

OLMIS-4574: Added functional test for authorizing a requisition
OLMIS-4574: Added functional test for authorizing a requisition
OLMIS-4999: restored requisition workflow performance tests
OLMIS-4999: restored requisition workflow performance tests