openlmis-requisition

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Release 8.0.0

OLMIS-6270: Added missing data builders in service, utils, validate and web tests
OLMIS-6270: Added missing data builders in service, utils, validate and web tests
OLMIS-6272: Added missing data builders in integration tests
OLMIS-6272: Added missing data builders in integration tests
OLMIS-6256: Added missing domain and dto data builder usages
OLMIS-6256: Added missing domain and dto data builder usages
OLMIS-6037: Standardize build statuses for all our Jenkins jobs
OLMIS-6037: Standardize build statuses for all our Jenkins jobs
Updated total losses and adjustments to equal -2

OLMIS-6037: Added unstable build status for testing failures

Revert "OLMIS-6037: Standardize build statuses for all our Jenkins jobs"

This reverts commit d770ebf1a67fd7017ec9e11a08fb1699f4347b7d.

OLMIS-6037: Standardize build statuses for all our Jenkins jobs

Ok. The duplication in the data builders has been removed. Exporter pattern is used where it's possible in the data buiders.

Ok. The duplication in the data builders has been removed. Exporter pattern is used where it's possible in the data buiders.

According to the DRY principle, we should not be duplicating code, especially that much. 1. Instead of adding another data builder we could add a buildDto method which would abstract the exporting ...

According to the DRY principle, we should not be duplicating code, especially that much.
1. Instead of adding another data builder we could add a buildDto method which would abstract the exporting part. This way we have both fast and easily used builders as well as no code duplication.
2. So can be using the DataBuilder pattern and duplicating such a big chunk of the code. As long as the complexity is low, and it is the same for a separate builder and using the exporter pattern, we should be good.
3. Same is true using the exporter pattern.

OLMIS-6272: Reworked requisition integration tests to use the data builder pattern
OLMIS-6272: Reworked requisition integration tests to use the data builder pattern
Well, according to the testing principles I think we should use a separated builder for DTO. 1. When we write tests, it's more convenient to use ClassDTO.build() instead of creating domain entity, ...

Well, according to the testing principles I think we should use a separated builder for DTO.
1. When we write tests, it's more convenient to use ClassDTO.build() instead of creating domain entity, empty DTO entity and then make an export method. Data builders are designed to write test fast and easily.
2. Using exporter pattern in creating the test object may be error-prone if something is wrong with export method. In unit testing, the objects should be created directly to make sure they are created exactly as expected - we should test only one functionality.
3. Some DTO builders had been already created before these changes committed.

This feels like a duplication of the RequisitionLineItemDataBuilder. Could we leverage the exporter pattern somehow? Same applies for similar DTO builders.

This feels like a duplication of the RequisitionLineItemDataBuilder. Could we leverage the exporter pattern somehow? Same applies for similar DTO builders.

OLMIS-6270: Refactored requisition service, utils, validate and web tests to use data builder...
OLMIS-6270: Refactored requisition service, utils, validate and web tests to use data builder...
OLMIS-6256: Refactored domain and dto tests to use data builder pattern
OLMIS-6256: Refactored domain and dto tests to use data builder pattern
Revert "Released requisition service 8.0.0-RC2"

This reverts commit 08db8e1ceec8dd2686aa02d3a28459e9fa966982.