openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6566: Updated changelog

OLMIS-6566: Updated test duration for getting 9000 FTAPs and searching orderables by version identities

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
Modified thresholds for performance tests

* FTAPs and Orderables are more restrictive now

* All Supply Lines with Expand is a little less restrictive

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

OLMIS-6611: Removed unnecessary method

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

True. The method was refactored.

True. The method was refactored.

OLMIS-6611: Refactored a method

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

OLMIS-6566: Removed unnecessary method from OrderableRepositoryImpl

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

Is that still necessary?

Is that still necessary?

We should be using constants for all of the literals

We should be using constants for all of the literals

OLMIS-6658 Cleaned some code

    • -3
    • +3
    /src/main/resources/api-definition.yaml
Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

Yes, we can! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif

Yes, we can!

Can't we use the constant from the abstract class?

Can't we use the constant from the abstract class?

This is needed for yet another partition in retrieving FTAPs (line 146)

This is needed for yet another partition in retrieving FTAPs (line 146)

We should extract all of those literals as constants

We should extract all of those literals as constants

Also, +1 for splitting the common code to a separate class. Good job!

Also, +1 for splitting the common code to a separate class. Good job!

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

Don't mention requisitions in referencedata

Don't mention requisitions in referencedata

Drop "or not"

Drop "or not"

Can't we request a specific version?

Can't we request a specific version?