openlmis-ref-distro

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I saw that there are more images that use openlmis/awscli image so there is definitely a need of versioning.

I saw that there are more images that use openlmis/awscli image so there is definitely a need of versioning.

Looks good. It might take the "single responsibility" principal a bit far (as in I could see one image for starting and stopping, or simply passing commands to the awscli image), however it looks f...

Looks good. It might take the "single responsibility" principal a bit far (as in I could see one image for starting and stopping, or simply passing commands to the awscli image), however it looks fully capable.

One aspect here that's a bit lacking is that if we're going to be building images off of the awscli image, then we should be versioning the awscli image. Without that versioning we will get to a house of cards scenario eventually, however this for now feels quite minor for this usage. Something to keep in mind if we take this further.

Done

Done

Don't we need to start the instance somehow? I can only see stopping and waiting? Is there something missing or does the instance starts automatically?

Don't we need to start the instance somehow? I can only see stopping and waiting? Is there something missing or does the instance starts automatically?

OLMIS-5728: added docker images for starting and stopping EC2 instances
OLMIS-5728: added docker images for starting and stopping EC2 instances
OK, my bad https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

OK, my bad

Check NotificationRepositoryCustom.java and that in this class there is no import from the web package

Check NotificationRepositoryCustom.java and that in this class there is no import from the web package

SearchParams class? I don't think so...

SearchParams class? I don't think so...

But this class is from repository custom interface https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

But this class is from repository custom interface

I think we should not pass SearchParams here as it is a class from web layer

I think we should not pass SearchParams here as it is a class from web layer

OLMIS-5859: Added query params to GET /notifications endpoint
OLMIS-5859: Added query params to GET /notifications endpoint
I'm not sure if I understand. Do you mean openlmis-demo-data? I don't see the compose file there... only Dockerfile and I've updated it based on openlmis-demo-data Dockerfile.

I'm not sure if I understand. Do you mean openlmis-demo-data? I don't see the compose file there... only Dockerfile and I've updated it based on openlmis-demo-data Dockerfile.

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

This should not be changed.

This should not be changed.

OLMIS-5467: Added script to wait for postgres
OLMIS-5467: Added script to wait for postgres
OLMIS-5668: Added endpoint to get user by id
OLMIS-5668: Added endpoint to get user by id
The pics do not render on RTD

The pics do not render on RTD

This table is broken and therefore does not render properly on RTD

This table is broken and therefore does not render properly on RTD

OLMIS-5388: Moved test strategy to readthedocs
OLMIS-5388: Moved test strategy to readthedocs