openlmis-notification

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sure, done.

Sure, done.

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that ...

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that all services have this switched on.

OLMIS-4531: Added compressing to HTTP POST responses

1. The ticket states that compression should be tested on initiating a requisition, that's why it is currently added only to the requisition service. 2. I think about disabling compression in nginx...

1. The ticket states that compression should be tested on initiating a requisition, that's why it is currently added only to the requisition service.
2. I think about disabling compression in nginx configuration.

Two questions: *Why was it only added to the requisition service? *It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way...

Two questions:

  • Why was it only added to the requisition service?
  • It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way to avoid that?
OLMIS-6040 Add documentation to README

About how to configure SMS integration.

OLMIS-4531: Added compressing to HTTP POST responses
OLMIS-4531: Added compressing to HTTP POST responses
OLMIS-6085: Fixed issue with rendering new line in digest notifications

OLMIS-6040 Fix class name

okay, my bad. We do this for email (only the important flag) but only because we check if a user email address has been verified and for important messages, this check can be skipped.

okay, my bad. We do this for email (only the important flag) but only because we check if a user email address has been verified and for important messages, this check can be skipped.

Shouldn't that be checked somewhere up the stream?

Shouldn't that be checked somewhere up the stream?

incorrect classes

incorrect classes

why we don't check allowNotify and important flags here?

why we don't check allowNotify and important flags here?

OLMIS-6040 Add SMS integration
OLMIS-6040 Add SMS integration
done

done

OLMIS-6029: Renamed classes in IT

It does not follow our naming convention for classes (using a verb).

It does not follow our naming convention for classes (using a verb).

I would say yes but probably no because you ask the question https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I would say yes but probably no because you ask the question

Is this a correct name for this class?

Is this a correct name for this class?

OLMIS-6040 Adjust how to handle error HTTP code from SMS API

For Sonar.

OLMIS-6040 Add dummy values for SMS integration

The build fails if default values are not set because the Jenkins env file does not have these keys set. Updating the Jenkins env file is not simple as it is unclear what is currently stored in Jenkins.

OLMIS-6040 Add SMS integration

* Add new SMS channel handler

* Add SMS sender, which connects to a service provider using an API URL and a token

* Request and response DTO matches TextIt/RapidPro API definition

OLMIS-6029: Fixed issues related to digest notifications
OLMIS-6029: Fixed issues related to digest notifications
OLMIS-6029: fixed broken unit test