openlmis-hapifhir

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5447: added check if transaction is rollback only
OLMIS-5447: added check if transaction is rollback only
OLMIS-5447: added check if transaction is rollback only

I created the review to make sure Lukas and you are aware of the auto-commit configuration changes. I will close this review.

I created the review to make sure Lukas and you are aware of the auto-commit configuration changes. I will close this review.

removed misleading method

removed misleading method

added

added

removed

removed

OLMIS-5415: added missing tests

OLMIS-5415: removed misleading private method

OLMIS-5415: added javadoc to ExternalApiException

OLMIS-5415: commit and rollback only if transaction is not completed

The name might be a little misleading. Wouldn't it make more sense to name it something telling us we're doing a request here?

The name might be a little misleading. Wouldn't it make more sense to name it something telling us we're doing a request here?

I think that this hides an important problem (201 being returned before the object is created). This information should definitely be propagated up and investigated.

I think that this hides an important problem (201 being returned before the object is created). This information should definitely be propagated up and investigated.

no, because we don't set id in the URL (the first parameter) and we use POST which basically is used to create objects. I created this private method to avoid code duplication.

no, because we don't set id in the URL (the first parameter) and we use POST which basically is used to create objects. I created this private method to avoid code duplication.

To make sure that a location on the FHIR server will be created. On CI there were situations where one request returns 201 status code but next one - which retrieve the object - returns 404 status ...

To make sure that a location on the FHIR server will be created. On CI there were situations where one request returns 201 status code but next one - which retrieve the object - returns 404 status code. I didn't have this locally so I thought that maybe we do something too fast in tests

This could use a Javadoc as the other newly-added exception have.

This could use a Javadoc as the other newly-added exception have.

Does this mean we will be able to update with this method aswell?

Does this mean we will be able to update with this method aswell?

I don't quite understand what needs to be reviewed here?

I don't quite understand what needs to be reviewed here?

Nevermind, I can see now.

Nevermind, I can see now.

Do we need this?

Do we need this?

What is it for?

What is it for?

OLMIS-5598: enable subscriptions in openlmis-hapifhir
OLMIS-5598: enable subscriptions in openlmis-hapifhir
OLMIS-5598: enable subscriptions in openlmis-hapifhir

Disable datasource auto-commit settings so that postgres specific error is avoided

-- Caused by: org.postgresql.util.PSQLException: Large Objects may not be used in auto-commit mode.

Remove code that requires manual activation of subscriptions.

done

done

OLMIS-5415: fixed typo