openlmis-fulfillment

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Disable caching of shipment templates. Makes it easier to test OLMIS-5832 - OLMIS-5835
Disable caching of shipment templates. Makes it easier to test OLMIS-5832 - OLMIS-5835
OLMIS-6010: improve test coverage
OLMIS-6010: improve test coverage
OLMIS-6010: improve test coverage

Bug Fix: rowsWithUnresolvedOrderable property should be visible in shipments api response

Remove unused setter, added a test

Makes sense. Thank you.

Makes sense. Thank you.

I would say it is better to use the same library to create and read JSON.

I would say it is better to use the same library to create and read JSON.

Split shipment error handler into a separate class to improve testability

Review feedback. Remove Gson and use Jackson for serializing unresolved orderable rows

Introduce methods to add line item and unresolved rows.

1. The code with Gson's implementation is one liner (Much simpler than jackson code I would be expected to write) 2. does not throw unhandled exception requiring further handling. 3. The library is...

1. The code with Gson's implementation is one liner (Much simpler than jackson code I would be expected to write) 2. does not throw unhandled exception requiring further handling. 3. The library is already available. I did not have to add it as a dependency in gradle file. Is Gson usage a significant problem that must be avoided?

Use existing MessageKeys instead of String.format

same here. Something like addLineItem would be easier to read and understand

same here. Something like addLineItem would be easier to read and understand

we should probably create a method instead of getting a field and modify it

we should probably create a method instead of getting a field and modify it

why we use Gson here? We use Jackson for JSON

why we use Gson here? We use Jackson for JSON

same here

same here

why we don't use messages from messages_en.properties?

why we don't use messages from messages_en.properties?

This commit contains work for two tickets. OLMIS-6010 and OLMIS-5986. This was a mistake I made and noticed only after I pushed the code. My apologies for this will make it harder to review.

This commit contains work for two tickets. OLMIS-6010 and OLMIS-5986. This was a mistake I made and noticed only after I pushed the code. My apologies for this will make it harder to review.

OLMIS-5986: For shipment files that did not process successfully, write an error log file in the errors...
OLMIS-5986: For shipment files that did not process successfully, write an error log file in the errors...
OLMIS-5985: Prefix archived shipment files with timestamp to avoid file name collision.
OLMIS-5985: Prefix archived shipment files with timestamp to avoid file name collision.