openlmis-contract-tests

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thanks for improving the code. You don't need to do it for this review, but would it be possible to put the code improvements in a separate review? That way the review could be focused on the featu...

Thanks for improving the code. You don't need to do it for this review, but would it be possible to put the code improvements in a separate review? That way the review could be focused on the feature change.

I am curious as to why some test classes extend ToStringContractTest and others extend EqualsContractTest? Why do some classes not need a ToString?

I am curious as to why some test classes extend ToStringContractTest and others extend EqualsContractTest? Why do some classes not need a ToString?

I don't quite understand this? What if the BaseDto has nothing to do with a requisition?

I don't quite understand this? What if the BaseDto has nothing to do with a requisition?

changed services versions to newest SNAPSHOTs

changed services versions to latest release

OLMIS-5138: Added originalRequisition extended property to Requisition model
OLMIS-5138: Added originalRequisition extended property to Requisition model
copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

Changed component versions to newest SNAPSHOTs

OLMIS-5642: Update requisition version

OLMIS-5752: Updated link to cucumber tags

OLMIS-5752: Updated links

OLMIS-5467: Updated dev version

OLMIS-5668: Added endpoint to get user by id
OLMIS-5668: Added endpoint to get user by id
OLMIS-5668: Updated auth version

Review Feedback - rename step.

I see that most of the changes have been made aside from the first one: "Given I am logged in as a service-client". Is that one difficult or is it simply a WIP?

I see that most of the changes have been made aside from the first one: "Given I am logged in as a service-client". Is that one difficult or is it simply a WIP?

I think the more-right solution is the first one. The second one likely is okay. The last is not desirable at all.

I think the more-right solution is the first one. The second one likely is okay. The last is not desirable at all.

LocationTests was where the step was used. LocationTests.feature file is updated.

LocationTests was where the step was used. LocationTests.feature file is updated.

Added new line at the end of .env file