openlmis-cce

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5841: Added tests to fix CCE build failing in sonar

Isn't this always true? rendering the subsequent lines to be a dead code?

Isn't this always true? rendering the subsequent lines to be a dead code?

OLMIS-5841: Fixed issue with internal server error when updating a catalog item with incorrect ID
OLMIS-5841: Fixed issue with internal server error when updating a catalog item with incorrect ID
OLMIS-5841: Fixed issue with internal server error when updating a catalog item with incorrect ID

Sure, I'm still working on that.

Sure, I'm still working on that.

Please add this to template service: https://github.com/OpenLMIS/openlmis-template-service/blob/master/build.gradle#L146
Unfortunately, it does so I reverted the changes and updated task for generating new migration.

Unfortunately, it does so I reverted the changes and updated task for generating new migration.

Updated task for generating migration to paste info about editing migrations

Revert "Added info about editing migrations"

This reverts commit c38878d51ec7cb44bc844e05fa738b3f64752f00.

    • -4
    • +0
    /src/main/resources/db/migration/20170810170921962__add_decommission_date_and_rtm_and_remove_serial_number.sql
    • -4
    • +0
    /src/main/resources/db/migration/20171114101548905__add_index_for_facilityId_and_programId_fields_in_inventory_item.sql
Hopefully comments do not modify the checksum, but yes - worth checking

Hopefully comments do not modify the checksum, but yes - worth checking

From what I know if a migration that has been applied to a database and it was changed the flyway will throw an exception (about incorrect code or something like that). Could we verify that those c...

From what I know if a migration that has been applied to a database and it was changed the flyway will throw an exception (about incorrect code or something like that). Could we verify that those comments will not break anything?

Added info about editing migrations
Added info about editing migrations
Added info about editing migrations

    • -0
    • +4
    /src/main/resources/db/migration/20170810170921962__add_decommission_date_and_rtm_and_remove_serial_number.sql
    • -0
    • +4
    /src/main/resources/db/migration/20171114101548905__add_index_for_facilityId_and_programId_fields_in_inventory_item.sql
OLMIS-4596: Shrinked demo data

    • -99962
    • +959
    /src/main/resources/db/demo-data/cce.cce_alerts.csv
I would keep the file because if I understand correctly if we would have problems with npm dependencies the file will help to resolve them.

I would keep the file because if I understand correctly if we would have problems with npm dependencies the file will help to resolve them.

I think yes, what do you think Nikodem Graczewski?

I think yes, what do you think Nikodem Graczewski?

should I remove the file and added it to .gitignore?

should I remove the file and added it to .gitignore?

this file was always in the repo. From what I see only some whitespaces have been removed

this file was always in the repo. From what I see only some whitespaces have been removed

Do we need this file?

Do we need this file?

Do we need this file?

Do we need this file?

because I use a stream to get usernames from the collection. If the log level is higher than Debug (like INFO) then there is no need to do that

because I use a stream to get usernames from the collection. If the log level is higher than Debug (like INFO) then there is no need to do that

why you've wrapped this logger call in if statement?

why you've wrapped this logger call in if statement?

OLMIS-4596: Fixed issue with sending notifications to users with home facility rights
OLMIS-4596: Fixed issue with sending notifications to users with home facility rights