openlmis-requisition

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I resolved this comment because of changes in FEOLMIS-3623

I resolved this comment because of changes in FEOLMIS-3623

I resolved this comment because of changes in FEOLMIS-3623

I resolved this comment because of changes in FEOLMIS-3623

I resolved this comment because of changes in FEOLMIS-3623

I resolved this comment because of changes in FEOLMIS-3623

I resolved this comment because of changes in FEOLMIS-3623

I resolved this comment because of changes in FEOLMIS-3623

OLMIS-5909: Added permission role check when requisition has not set supervisoryNodeId field
OLMIS-5909: Added permission role check when requisition has not set supervisoryNodeId field
OLMIS-5886 : Add `Additional quantity required` column in Requisition print
OLMIS-5886 : Add `Additional quantity required` column in Requisition print
when we authorize via endpoint the supervisory node id field is set in BaseRequisitionController.assignInitialSupervisoryNode (current line 438-445 in BaseRequisitionController)

when we authorize via endpoint the supervisory node id field is set in BaseRequisitionController.assignInitialSupervisoryNode (current line 438-445 in BaseRequisitionController)

we did not do this before (because we use permission strings) but after we change the check to role assignment this provide false information that user has no access to requisition

we did not do this before (because we use permission strings) but after we change the check to role assignment this provide false information that user has no access to requisition

changes are: https://review.openlmis.org/cru/FEOLMIS-3623

changes are: https://review.openlmis.org/cru/FEOLMIS-3623

OLMIS-5909: Refactored Permission Service
OLMIS-5909: Refactored Permission Service
I moved right/role check to new classes and to avoid too many changes in this review I create a new one: https://review.openlmis.org/cru/FEOLMIS-3623

I moved right/role check to new classes and to avoid too many changes in this review I create a new one: https://review.openlmis.org/cru/FEOLMIS-3623

done

done

Done

Done

The changelog is already there for this ticket, this one was only fixing some issue introduced by earlier changes made in this ticket.

The changelog is already there for this ticket, this one was only fixing some issue introduced by earlier changes made in this ticket.

What about changelog? I know that there were a lot of changes related to the ticket so if the changelog was added earlier or will be added later then I am ok

What about changelog? I know that there were a lot of changes related to the ticket so if the changelog was added earlier or will be added later then I am ok