openlmis-requisition

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I wanted to separate loading csv files from services (as from demo-data directory in each service) from those which are in the demo-data repository. Just for the sake of clarity.

I wanted to separate loading csv files from services (as from demo-data directory in each service) from those which are in the demo-data repository. Just for the sake of clarity.

Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

OLMIS-6374 Fix typo in script name.
OLMIS-6374 Fix typo in script name.
OLMIS-6382: Removed usage deprecated endpoint api/facilities/supplying and use instead api/supplyLines...
OLMIS-6382: Removed usage deprecated endpoint api/facilities/supplying and use instead api/supplyLines...
Okay, let me check if I can work on that performance data first, I will ask for help on help channel if I face any challenges

Okay, let me check if I can work on that performance data first, I will ask for help on help channel if I face any challenges

Hello Ian. The lack of requisitions can be caused by this bug - OLMIS-6374. Maybe this is something you can look into? If not, it will be scheduled into our next sprint.

Hello Ian. The lack of requisitions can be caused by this bug - OLMIS-6374. Maybe this is something you can look into? If not, it will be scheduled into our next sprint.

Hello Sebastian Brudziński I was using requisitions with IN_APPROVAL for Essential Meds but I think now they have been removed from demo data, there is only two requisitions for ARV program and the...

Hello Sebastian Brudziński I was using requisitions with IN_APPROVAL for Essential Meds but I think now they have been removed from demo data, there is only two requisitions for ARV program and the problem with using those is test will fail with this message "because it has been split or it is part of split requisition."....any suggestion?

Noted

Noted

The prepareRequisitions part may not be required, but if you look at the save and approve endpoints, they use an additional request parameter that completely changes the behavior of this endpoint -...

The prepareRequisitions part may not be required, but if you look at the save and approve endpoints, they use an additional request parameter that completely changes the behavior of this endpoint - enables batch saving and approving. This part is not covered in regular requisition tests.

figured out were not related to what we want this test to do which is to test approval of batch requisitions, most of them are already tested on requisition flow test

figured out were not related to what we want this test to do which is to test approval of batch requisitions, most of them are already tested on requisition flow test

undesired empty lines

undesired empty lines

Why were half of those tests removed?

Why were half of those tests removed?

I'd change 'check' to 'update' or 'correct' to emphasize that this method may modify somehow the entity

I'd change 'check' to 'update' or 'correct' to emphasize that this method may modify somehow the entity

please consider adding some test

please consider adding some test

noted

noted

If so, this functionality could be extracted to a separate class and used in both places. Changing any value in a validator is very misleading.

If so, this functionality could be extracted to a separate class and used in both places. Changing any value in a validator is very misleading.

In my opinion it should not be here. However, this moment in workflow has all data that we need to check if the value is null (and if the column is not set) Otherwise, I have to duplicate code whic...

In my opinion it should not be here. However, this moment in workflow has all data that we need to check if the value is null (and if the column is not set) Otherwise, I have to duplicate code which extract data from requisition with all of RequisitionLineItems and extract all fields (e.g average consumption) and then check them for example in RequisitionController.

I think if it is a fix related to database update, it should be committed just before update action (after validation)

I think if it is a fix related to database update, it should be committed just before update action (after validation)

This functionality could be extracted to a method with an explaining, clear name

This functionality could be extracted to a method with an explaining, clear name

could we add a short description (as a comment) why we provided this change? Also, I am not sure if this should be in the validator class. Maybe this should be done earlier/another layer. The valid...

could we add a short description (as a comment) why we provided this change? Also, I am not sure if this should be in the validator class. Maybe this should be done earlier/another layer. The validator should only validate data, it should not modify them

OLMIS-6230 Fix bug with null value of average consumption when column is not selected in template.
OLMIS-6230 Fix bug with null value of average consumption when column is not selected in template.