openlmis-function-decorator

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6442: Fixed getting arguments in function decorator

    • -0
    • +13
    ./openlmis-function-decorator.spec.js
OLMIS-6442: Removed console log

OLMIS-6442: Added withConfirm function to FunctionDecorator class

    • -3
    • +70
    ./openlmis-function-decorator.spec.js
  1. … 1 more file in changeset.
Missing unit tests.

Missing unit tests.

MIssing JSDocs.

MIssing JSDocs.

Nevermind.

Nevermind.

Is this required if we only have single accessRight?

Is this required if we only have single accessRight?

Missing JSDoc.

Missing JSDoc.

FTAP or facility type approved products

FTAP or facility type approved products

Could we add a "withConfirm" method to the FunctionDecorator?

Could we add a "withConfirm" method to the FunctionDecorator?

Any reason why this is in a separate file? Are we reusing it somewhere?

Any reason why this is in a separate file? Are we reusing it somewhere?

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like: .extend({}, result.content[0], vm.facilityTypeApprovedProduct)

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like:
.extend({}, result.content[0], vm.facilityTypeApprovedProduct)

This could be a call to the goToFtapsList instead.

This could be a call to the goToFtapsList instead.

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?

Change andCallFake(function(){ return context.$q.resolve()} ) to andReturn(this.$q.resolve())

Change andCallFake(function()

Unknown macro: { return context.$q.resolve()}

) to andReturn(this.$q.resolve())

This can be part of the controller.

This can be part of the controller.

Fixed

Fixed

the same 'confirmService' is in 27 line

the same 'confirmService' is in 27 line

OLMIS-6442: Added UI for FTAPs
OLMIS-6442: Added UI for FTAPs
OLMIS-6020: Added the ability to leave loading modal open after resolving promise in...
OLMIS-6020: Added the ability to leave loading modal open after resolving promise in...
OLMIS-6020: Added the ability to leave loading modal open after resolving promise in FunctionDecorator

    • -0
    • +14
    ./openlmis-function-decorator.spec.js
OLMIS-6020: Added FunctionDecorator class
OLMIS-6020: Added FunctionDecorator class
OLMIS-6020: Removed ddescribe

OLMIS-6020: Added FunctionDecorator class

    • -0
    • +158
    ./openlmis-function-decorator.js
    • -0
    • +30
    ./openlmis-function-decorator.module.js
    • -0
    • +246
    ./openlmis-function-decorator.spec.js
  1. … 1 more file in changeset.