package-yarn.json

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I added it

I added it

I meant only throwMethodNotSupported and getAll https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I meant only throwMethodNotSupported and getAll

Tests for update, create and delete are on me https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Tests for update, create and delete are on me

Maybe we could extract this date to variable and define it globally?

Maybe we could extract this date to variable and define it globally?

Please change "non versioned" to "nonversioned" or "non-versioned".

Please change "non versioned" to "nonversioned" or "non-versioned".

not the latest version, probably

not the latest version, probably

Please change the description to not contain "2" at the end.

Please change the description to not contain "2" at the end.

Do we have some tests for those functions?

Do we have some tests for those functions?

OLMIS-6487: Added functions to get latest and versioned documents from local database
OLMIS-6487: Added functions to get latest and versioned documents from local database
OLMIS-6487: Added functions to get latest and versioned documents from local database

  1. … 3 more files in changeset.
OLMIS-6380: Added openlmis-datetime module
OLMIS-6380: Added openlmis-datetime module
OLMIS-6380: Added openlmis-datetime module

  1. … 8 more files in changeset.
Done.

Done.

What about chained function calls, like moment.tz().format()?

What about chained function calls, like moment.tz().format()?

Something like this: https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-function-decorator/openlmis-function-decorator.spec.js
Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Great, thanks!

Great, thanks!

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

https://openlmis.atlassian.net/browse/OLMIS-6170

https://openlmis.atlassian.net/browse/OLMIS-6170

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

Also changed the currency filter in ui-components to use the new localeService.

Also changed the currency filter in ui-components to use the new localeService.