openlmis-ui-components

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6167: Fixed issue with a weird popover showing after using enter on the select product modal

OLMIS-6020: Hour and Minute inputs of openlmisCronSelection directive will now accept only positive integer

OLMIS-4944 Improve testing setup for date filters

Based on code review feedback.

Done.

Done.

OLMIS-4944 Improve testing setup for period filter

Based on code review feedback.

    • -26
    • +7
    /src/openlmis-date/period.filter.spec.js
What about chained function calls, like moment.tz().format()?

What about chained function calls, like moment.tz().format()?

Something like this: https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-function-decorator/openlmis-function-decorator.spec.js
Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

OLMIS-6020: Added the ability to leave loading modal open after resolving promise in...
OLMIS-6020: Added the ability to leave loading modal open after resolving promise in...
Great, thanks!

Great, thanks!

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

https://openlmis.atlassian.net/browse/OLMIS-6170

https://openlmis.atlassian.net/browse/OLMIS-6170

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

OLMIS-6020: Fixed linting issues

OLMIS-6020: Fixed ESlint issues and bug with cron expression being required when hidden

Also changed the currency filter in ui-components to use the new localeService.

Also changed the currency filter in ui-components to use the new localeService.

Done.

Done.

Reduced the duplication.

Reduced the duplication.

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

Move component to 7.1.0-SNAPSHOT

Since it has new functionality now.

OLMIS-4944 Make changes based on review feedback

* Move checking for defaults from filters to locale service.

* Remove extra promise logic in locale service.

* Add to changelog.

    • -5
    • +28
    /src/openlmis-date/period.filter.spec.js
Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.

Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.