openlmis-ui-components

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "OLMIS-6222: Added paginationId attribute to pagination"

This reverts commit 05e09a1feda4b94024c2be546c75bffc1adc4cb1.

OLMIS-6222: Added paginationId attribute to pagination

OLMIS-6441: Added directive positive-decimal
OLMIS-6441: Added directive positive-decimal
OLMIS-6441: Added missing test for positive decimal directive

    • -0
    • +61
    /src/openlmis-form/positive-decimal.directive.spec.js
OLMIS-6441: Added directive positive-decimal

OLMIS-6473 Rename openlmisDatetime filter
OLMIS-6473 Rename openlmisDatetime filter
Feel free to add a more appropriate reviewer.

Feel free to add a more appropriate reviewer.

OLMIS-6473 Rename openlmisDatetime filter

There already exists a filter with this name. This new filter does not seem to be as robust, as it does not use the system timezone setting.

    • -6
    • +6
    /src/openlmis-datetime/datetime.filter.js
OLMIS-6442: Fixed getting arguments in function decorator

OLMIS-6442: Removed console log

OLMIS-6442: Added withConfirm function to FunctionDecorator class

Missing unit tests.

Missing unit tests.

MIssing JSDocs.

MIssing JSDocs.

Nevermind.

Nevermind.

Is this required if we only have single accessRight?

Is this required if we only have single accessRight?

Missing JSDoc.

Missing JSDoc.

FTAP or facility type approved products

FTAP or facility type approved products

Could we add a "withConfirm" method to the FunctionDecorator?

Could we add a "withConfirm" method to the FunctionDecorator?

Any reason why this is in a separate file? Are we reusing it somewhere?

Any reason why this is in a separate file? Are we reusing it somewhere?

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like: .extend({}, result.content[0], vm.facilityTypeApprovedProduct)

Could we make the save function accept an object and use .extend instead of updating the object by hand? This would be something like:
.extend({}, result.content[0], vm.facilityTypeApprovedProduct)

This could be a call to the goToFtapsList instead.

This could be a call to the goToFtapsList instead.

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?

This will not always return to the Ftaps list. Was there a requirement that we go back to the previous state instead of ftap list?

Change andCallFake(function(){ return context.$q.resolve()} ) to andReturn(this.$q.resolve())

Change andCallFake(function()

Unknown macro: { return context.$q.resolve()}

) to andReturn(this.$q.resolve())