application.properties

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sure, done.

Sure, done.

OLMIS-4531: Added compressing to HTTP POST responses

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that ...

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that all services have this switched on.

1. The ticket states that compression should be tested on initiating a requisition, that's why it is currently added only to the requisition service. 2. I think about disabling compression in nginx...

1. The ticket states that compression should be tested on initiating a requisition, that's why it is currently added only to the requisition service.
2. I think about disabling compression in nginx configuration.

Two questions: *Why was it only added to the requisition service? *It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way...

Two questions:

  • Why was it only added to the requisition service?
  • It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way to avoid that?
OLMIS-4531: Added compressing to HTTP POST responses
OLMIS-4531: Added compressing to HTTP POST responses
OLMIS-5385: updated template service
OLMIS-5385: updated template service
I still need to fix 3 code smells from sonar. Two of them are related to missing tests and one is related to fact that the class extends other class that has some tests but does not contain any tes...

I still need to fix 3 code smells from sonar. Two of them are related to missing tests and one is related to fact that the class extends other class that has some tests but does not contain any test

OLMIS-5385: updated template service

  1. … 70 more files in changeset.
remove redundant application property

Łukasz LewczyńskiFEOLMIS-2134
I still can see it in template service, if we don't need it anymore we should update template service

I still can see it in template service, if we don't need it anymore we should update template service

program: FEOLMIS-2133

program: FEOLMIS-2133

we don't have it. Mateusz Kwiatkowski it was in template service, right? I think it's redundant but let's check

we don't have it. Mateusz Kwiatkowski it was in template service, right? I think it's redundant but let's check

If you decide to move referencedata fields to single class Please do this as a separate review and add link here

If you decide to move referencedata fields to single class Please do this as a separate review and add link here

Do we have spring.data.rest.base-path in other services? Maybe we could remove this property? Yes, I think it would be good to have this in one place.

Do we have spring.data.rest.base-path in other services? Maybe we could remove this property? Yes, I think it would be good to have this in one place.

by the way, in *services we use strings like "/api/facilities/, the API part is also static field in BaseController and in appication.properties in spring.data.rest.base-path (I wonder what is the ...

by the way, in *services we use strings like "/api/facilities/, the API part is also static field in BaseController and in appication.properties in spring.data.rest.base-path (I wonder what is the use of this, we set "api" part in controller, why spring need that?). It would be good to have that "api" in one place too?

Łukasz Lewczyński It will not be removed but I think it should be in one place? Maybe some "static" class in service package?

Łukasz Lewczyński It will not be removed but I think it should be in one place? Maybe some "static" class in service package?

Chongsun Ahn Łukasz Lewczyński review for user FEOLMIS-2132
I think it could be in this class or in the FacilityReferenceDataService class if the service will not be removed from the cce service.

I think it could be in this class or in the FacilityReferenceDataService class if the service will not be removed from the cce service.

ok

ok

constant where?

constant where?

Please, add link here when review will be created

Please, add link here when review will be created