Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix bug in PUT of widget APIs

When calling PUT on a specific resource, if it is not found, it should not return a 404 Not Found, but rather should create the resource in the system with the id provided in the path.

  1. … 2 more files in changeset.
OLMIS-6851 Update service template to use Spring Boot 2

* Remove Flyway testing pattern, as it is not recommended and does not work with how Flyway is set up now.

* Update checkstyle and PMD. PMD is not latest, as it would create code change challenges.

* Update Dev and db images to use latest and Debezium, respectively.

    • -6
    • +3
    ./openlmis/template/CustomWebMvcConfigurerAdapter.java
    • -20
    • +30
    ./openlmis/template/ExportSchemaFlywayCallback.java
  1. … 23 more files in changeset.
OLMIS-6374 Add new profile for audit logging.

  1. … 1 more file in changeset.
OLMIS-5385: removed unused import

    • -1
    • +0
    ./openlmis/template/util/Resource2Db.java
OLMIS-5385: changed try to try-with-resources

    • -5
    • +2
    ./openlmis/template/util/Resource2Db.java
OLMIS-5385: fixed sonar issues

    • -14
    • +17
    ./openlmis/template/util/Resource2Db.java
    • -7
    • +2
    ./openlmis/template/web/BaseController.java
  1. … 2 more files in changeset.
OLMIS-5385: resolved sonar issues

    • -0
    • +14
    ./openlmis/template/domain/Widget.java
    • -6
    • +25
    ./openlmis/template/i18n/MessageKeys.java
    • -1
    • +0
    ./openlmis/template/util/Resource2Db.java
    • -36
    • +3
    ./openlmis/template/web/BaseController.java
    • -0
    • +1
    ./openlmis/template/web/widget/WidgetDto.java
  1. … 8 more files in changeset.
OLMIS-5385: updated template service
OLMIS-5385: updated template service
I still need to fix 3 code smells from sonar. Two of them are related to missing tests and one is related to fact that the class extends other class that has some tests but does not contain any tes...

I still need to fix 3 code smells from sonar. Two of them are related to missing tests and one is related to fact that the class extends other class that has some tests but does not contain any test

OLMIS-5385: updated template service

    • -18
    • +13
    ./openlmis/template/Application.java
    • -3
    • +4
    ./openlmis/template/CustomWebMvcConfigurerAdapter.java
    • -0
    • +77
    ./openlmis/template/ExportSchemaFlywayCallback.java
    • -0
    • +63
    ./openlmis/template/TestDataInitializer.java
    • -3
    • +22
    ./openlmis/template/domain/BaseEntity.java
    • -0
    • +32
    ./openlmis/template/domain/ConditionalUuidGenerator.java
    • -0
    • +28
    ./openlmis/template/domain/CustomPhysicalNamingStrategy.java
    • -1
    • +38
    ./openlmis/template/domain/Widget.java
    • -0
    • +3
    ./openlmis/template/i18n/MessageKeys.java
  1. … 56 more files in changeset.
OLMIS-3078 implemented improvement for Javers Log Initializer

    • -0
    • +3
    ./openlmis/template/i18n/MessageKeys.java
  1. … 2 more files in changeset.
I think this file should be removed

I think this file should be removed

OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style

fixed LICENCE header

fixed import order

fixed minor code style issues

    • -5
    • +4
    ./openlmis/template/CustomWebMvcConfigurerAdapter.java
    • -8
    • +7
    ./openlmis/template/domain/BaseEntity.java
    • -7
    • +6
    ./openlmis/template/domain/Widget.java
    • -3
    • +3
    ./openlmis/template/i18n/MessageKeys.java
    • -3
    • +3
    ./openlmis/template/i18n/MessageService.java
  1. … 16 more files in changeset.
LGTM

LGTM

I removed this constant and create a new one NO_PAGINATION.

I removed this constant and create a new one NO_PAGINATION.

OLMIS-2534: Set page size to 2000 in AuditLogInitializer

OLMIS-2534: Renamed DEFAULT_PAGE_SIZE to NO_PAGINATION

    • -1
    • +1
    ./openlmis/template/CustomWebMvcConfigurerAdapter.java
    • -3
    • +3
    ./openlmis/template/util/Pagination.java
Moreover I still don't like this constant. Isn't the default page size in OpenLMIS 10?

Moreover I still don't like this constant. Isn't the default page size in OpenLMIS 10?

These returned all items, now they will return 2000 - I doubt we want that behavior change. I didn't check the other repos, but I assume we can have the same issue there.

These returned all items, now they will return 2000 - I doubt we want that behavior change. I didn't check the other repos, but I assume we can have the same issue there.

https://github.com/OpenLMIS/openlmis-requisition/search?utf8=%E2%9C%93&q=DEFAULT_PAGE_SIZE&type=
According to the old description it seems like even if this value was Integer.MAX_VALUE the result set/list should not have more than 2000 elements. Also could you provide example where this variab...

According to the old description it seems like even if this value was Integer.MAX_VALUE the result set/list should not have more than 2000 elements. Also could you provide example where this variable is used to retrieve all data?

Łukasz Lewczyński I'm pretty sure we were using this value in other places, where we wanted to retrieve all the items

Łukasz Lewczyński I'm pretty sure we were using this value in other places, where we wanted to retrieve all the items