Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6851 Update service template to use Spring Boot 2

* Remove Flyway testing pattern, as it is not recommended and does not work with how Flyway is set up now.

* Update checkstyle and PMD. PMD is not latest, as it would create code change challenges.

* Update Dev and db images to use latest and Debezium, respectively.

  1. … 30 more files in changeset.
OLMIS-3708: Introduced API Console

  1. … 3 more files in changeset.
Paweł Gesek Mateusz Kwiatkowski Created OLMIS-2849 -> this review can be closed.

Paweł Gesek Mateusz Kwiatkowski Created OLMIS-2849 -> this review can be closed.

Mateusz Kwiatkowski Paweł Nawrocki do we have a ticket for updating the template service? If no, can you create one so we can close this review?

Mateusz Kwiatkowski Paweł Nawrocki do we have a ticket for updating the template service? If no, can you create one so we can close this review?

I don't see an issue - we used maven resource filtering for cases like this in the past, Gradle probably has something along those lines as well. The directory part is a bummer, but also solvable ...

I don't see an issue - we used maven resource filtering for cases like this in the past, Gradle probably has something along those lines as well.

The directory part is a bummer, but also solvable - gradle should copy the file to a different dir in /build, it will require some configuration in the task. At the very least we can create a ticket for removing these hardcoded parts - but for now we would at least to mention all of them in the README.

Is this even possible to use gradle property in this json? another problem is that "template" is also directory name, so how we are going to make it dynamic?

Is this even possible to use gradle property in this json? another problem is that "template" is also directory name, so how we are going to make it dynamic?

Yeah, ideally this should be one prop in gradle.properties and replaced at runtime, here we should only use ${servicePath} or something more appropriate if it is already defined. You can easily do ...

Yeah, ideally this should be one prop in gradle.properties and replaced at runtime, here we should only use ${servicePath} or something more appropriate if it is already defined. You can easily do that with Maven, I'm sure it's the same with Gradle.

And here?

And here?

And here?

And here?

If we're talking about configuring hardcoded stuff, then this is also one of the places.

If we're talking about configuring hardcoded stuff, then this is also one of the places.

Another place ideal to control through same sort of gradle build time replacement

Another place ideal to control through same sort of gradle build time replacement

cce?

cce?

Is this the service name? Is there any way to get rid of this painpoint - implementers have to change this line in their service right? Can we use a gradle property here?

Is this the service name? Is there any way to get rid of this painpoint - implementers have to change this line in their service right? Can we use a gradle property here?

updated template service to match current state of our services
updated template service to match current state of our services
updated template service to match current state of our services

  1. … 11 more files in changeset.
looks good

looks good

This should be 'template-service' I guess

This should be 'template-service' I guess

Probably it was removed by accident

Probably it was removed by accident

What was the reason for removing that?

What was the reason for removing that?

OLMIS-2752: updated postgres + openlmis/dev versions
OLMIS-2752: updated postgres + openlmis/dev versions
OLMIS-2752: updated postgres + openlmis/dev versions

  1. … 5 more files in changeset.
Bump spring version; update outdated classes and configs

  1. … 13 more files in changeset.
Bump spring version; update outdated classes and configs

  1. … 13 more files in changeset.
OLMIS-1599: Port the Swagger fix from requisitions to template-service

  1. … 1 more file in changeset.
OLMIS-1599 - Port the Swagger fix from requisitions to other services

  1. … 1 more file in changeset.