Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6558 Update README with description of the new env variable - P… (#17)

* OLMIS-6558 Update README with description of the new env variable - PUBLIC_URL

* OLMIS-6558 Add information about optionality of PUBLIC_URL.

OLMIS-6558 Add information about optionality of PUBLIC_URL.

OLMIS-6558 Update README with description of the new env variable - PUBLIC_URL

OLMIS-2923: Fixed broken link

OLMIS-2923: Provide example demo data to template service
OLMIS-2923: Provide example demo data to template service
OLMIS-2923: Provide example demo data to template service

  1. … 8 more files in changeset.
Update README.md

MW-412: Add a description of CORS-related environment variables to the readme

MW-412: Add a description of CORS-related environment variables to the readme

MW-412: Update README

why defaultLocale, not locale?

why defaultLocale, not locale?

Agree, the code shouldn't be changed if it doesn't have to.

Agree, the code shouldn't be changed if it doesn't have to.

why not just call this locale and do locale = ${LOCALE:en} here?

why not just call this locale and do locale = ${LOCALE:en} here?

OLMIS-2611: added using LOCALE variable from env

  1. … 1 more file in changeset.
We do

We do

Don't we want to have default locale?

Don't we want to have default locale?

Update the template service as well. Moreover, document the var in its README - https://github.com/OpenLMIS/openlmis-template-service/blob/master/README.md#environment-variables

Update the template service as well. Moreover, document the var in its README - https://github.com/OpenLMIS/openlmis-template-service/blob/master/README.md#environment-variables

This should go to the top section of this file - this is not a build setting

This should go to the top section of this file - this is not a build setting

I don't think we need to capture this - we don't want to silently ignore misconfiguration

I don't think we need to capture this - we don't want to silently ignore misconfiguration

OLMIS-2611: Added using locale from env file.
OLMIS-2611: Added using locale from env file.
All fixed. THanks!

All fixed. THanks!

My comments are all resolved. LGTM.

My comments are all resolved. LGTM.

Agreed. Perhaps we can leave localhost for virtual host. It won't work, but the docs need to point out it needs to be updated. Consul to me made sense to turn blank as setting it actually would bre...

Agreed. Perhaps we can leave localhost for virtual host. It won't work, but the docs need to point out it needs to be updated. Consul to me made sense to turn blank as setting it actually would break it more often than not. The default value, consul, works just fine. I'm open to whatever makes VIRTUAL_HOST and BASE_URL the most clear.

Made it blank

Made it blank

Done

Done