Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Paweł Gesek Mateusz Kwiatkowski Created OLMIS-2849 -> this review can be closed.

Paweł Gesek Mateusz Kwiatkowski Created OLMIS-2849 -> this review can be closed.

Mateusz Kwiatkowski Paweł Nawrocki do we have a ticket for updating the template service? If no, can you create one so we can close this review?

Mateusz Kwiatkowski Paweł Nawrocki do we have a ticket for updating the template service? If no, can you create one so we can close this review?

I don't see an issue - we used maven resource filtering for cases like this in the past, Gradle probably has something along those lines as well. The directory part is a bummer, but also solvable ...

I don't see an issue - we used maven resource filtering for cases like this in the past, Gradle probably has something along those lines as well.

The directory part is a bummer, but also solvable - gradle should copy the file to a different dir in /build, it will require some configuration in the task. At the very least we can create a ticket for removing these hardcoded parts - but for now we would at least to mention all of them in the README.

Is this even possible to use gradle property in this json? another problem is that "template" is also directory name, so how we are going to make it dynamic?

Is this even possible to use gradle property in this json? another problem is that "template" is also directory name, so how we are going to make it dynamic?

Yeah, ideally this should be one prop in gradle.properties and replaced at runtime, here we should only use ${servicePath} or something more appropriate if it is already defined. You can easily do ...

Yeah, ideally this should be one prop in gradle.properties and replaced at runtime, here we should only use ${servicePath} or something more appropriate if it is already defined. You can easily do that with Maven, I'm sure it's the same with Gradle.

And here?

And here?

And here?

And here?

If we're talking about configuring hardcoded stuff, then this is also one of the places.

If we're talking about configuring hardcoded stuff, then this is also one of the places.

Another place ideal to control through same sort of gradle build time replacement

Another place ideal to control through same sort of gradle build time replacement

cce?

cce?

Is this the service name? Is there any way to get rid of this painpoint - implementers have to change this line in their service right? Can we use a gradle property here?

Is this the service name? Is there any way to get rid of this painpoint - implementers have to change this line in their service right? Can we use a gradle property here?

updated template service to match current state of our services
updated template service to match current state of our services
updated template service to match current state of our services

  1. … 11 more files in changeset.
Bump spring version; update outdated classes and configs

  1. … 13 more files in changeset.
Bump spring version; update outdated classes and configs

  1. … 13 more files in changeset.
OLMIS-1326 Add RAML & Swagger setup to the template service

  1. … 9 more files in changeset.
OLMIS-765 Add Transifex sync to build

Add Transifex into the development and build processes. Change the build process to use a script, rather than call gradle build directly, so that the build is in two steps--transifex and gradle.

Update documentation about Transifex. Remove translated file.

  1. … 5 more files in changeset.
OLMIS-656 hand database connection credentials to container

Instead of having db credentials hardcoded in the gradle build and Spring Boot app properties file, have those settings take it from the environment, which is passed in through an environment file during docker compose.

  1. … 5 more files in changeset.
Initial commit

  1. … 7 more files in changeset.