Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

Not really, this list will only change if someone adds the product to draft, I was thinking of running this filter after adding a new product but I wasn't sure if I was covering all cases so this a...

Not really, this list will only change if someone adds the product to draft, I was thinking of running this filter after adding a new product but I wasn't sure if I was covering all cases so this approach is safer.

We should test this.

We should test this.

This might prove to be non-performant. Is there any way we could avoid using a watch here?

This might prove to be non-performant. Is there any way we could avoid using a watch here?

No changelog needed as it was introduced after the last release.

No changelog needed as it was introduced after the last release.

OLMIS-5586: fixed problem with grouping line items on physical inventory screen
OLMIS-5586: fixed problem with grouping line items on physical inventory screen
OLMIS-5586: fixed problem with grouping line items on physical inventory screen

  1. … 2 more files in changeset.
Good point, I forgot about removing products on this screen, resolving

Good point, I forgot about removing products on this screen, resolving

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

Move this out of the inject into the beforeEach function.

Move this out of the inject into the beforeEach function.

1. I don't think this parameter is Integer type. rather a String type 2. this should be @param 3. add @return below with type Array 4. fix indentation as in other jsdocs so descriptions and paramet...

1. I don't think this parameter is Integer type. rather a String type
2. this should be @param
3. add @return below with type Array
4. fix indentation as in other jsdocs so descriptions and parameter names are aligned

This should be a DataBuilder so it can be reused.

This should be a DataBuilder so it can be reused.

I think that maybe you should do filtering (grouping) on entering the screen (i.e. in routes file) so you don't have to use memoize here

I think that maybe you should do filtering (grouping) on entering the screen (i.e. in routes file) so you don't have to use memoize here

please you remove '_' from this parameter name

please you remove '_' from this parameter name

OLMIS-5438 Categorize orderables under correct product categories
OLMIS-5438 Categorize orderables under correct product categories
OLMIS-5438 Display Products within the Product Categories on the Physical Inventory

  1. … 3 more files in changeset.
OLMIS-3921: change badge to new column

  1. … 5 more files in changeset.
it will be removed anyway

it will be removed anyway

ugh — this generic reasons class scares me — why do we need !important — what styling are we trying to make work? ideally we would never use important ever

ugh — this generic reasons class scares me — why do we need !important — what styling are we trying to make work?

ideally we would never use important ever

Thanks for doing this Paweł Albecki (even though I just changed the AC

Thanks for doing this Paweł Albecki (even though I just changed the AC

I wouldn't make this a directive (its already in a directive) please use bootstrap's badge css class (its what I applied in the mock-up) https://getbootstrap.com/docs/3.3/components/#badges

I wouldn't make this a directive (its already in a directive)

please use bootstrap's badge css class (its what I applied in the mock-up)
https://getbootstrap.com/docs/3.3/components/#badges

Remove this - we want to avoid adding CSS like this because it will be really hard to find again Yes, I know we do this all over the place — and its an issue — an example of it going badly is some...

Remove this - we want to avoid adding CSS like this because it will be really hard to find again

Yes, I know we do this all over the place — and its an issue — an example of it going badly is somehow the icons in some places got italicized

there will be more work for this service within ticket

there will be more work for this service within ticket