Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6556: Adjust the source-destination service to use new parameters

    • -6
    • +6
    ./stock-adjustment-creation/source-destination.service.js
    • -1
    • +1
    ./stock-issue-creation/issue-creation.routes.js
    • -1
    • +1
    ./stock-receive-creation/receive-creation.routes.js
  1. … 1 more file in changeset.
OLMIS-6556 Rename parameters in source destination service and change version to 2.0.4

    • -6
    • +6
    ./stock-adjustment-creation/source-destination.service.js
  1. … 1 more file in changeset.
OLMIS-6556 Adjust the source-destination service to use new parameters

    • -6
    • +6
    ./stock-adjustment-creation/source-destination.service.js
    • -1
    • +1
    ./stock-issue-creation/issue-creation.routes.js
    • -1
    • +1
    ./stock-receive-creation/receive-creation.routes.js
  1. … 1 more file in changeset.
Added LotResource to fix splitting long requests
Added LotResource to fix splitting long requests
Refactored usages of LotRepositoryImpl to use LotResource because the second one implements splitting long requests

    • -5
    • +5
    ./stock-card-summary/stock-card-summary-repository-impl.js
    • -7
    • +7
    ./stock-card-summary/stock-card-summary-repository-impl.spec.js
    • -10
    • +1
    ./stock-orderable-group/orderable-group.service.spec.js
    • -7
    • +7
    ./stock-products/full-stock-card-summary-repository-impl.js
    • -8
    • +8
    ./stock-products/full-stock-card-summary-repository-impl.spec.js
Revert "OLMIS-6328: Adjusted tests to support lack of calling fulfill endpoint"

This reverts commit 309f3912

    • -0
    • +18
    ./stock-products/full-stock-card-summary-repository-impl.spec.js
Revert "OLMIS-6328: Adjusted tests to support lack of calling fulfill endpoint"

This reverts commit 309f3912

    • -0
    • +18
    ./stock-products/full-stock-card-summary-repository-impl.spec.js
Revert "OLMIS-6328: Removed unnecessary call to /orderableFullfils"

This reverts commit 44989e3d

    • -37
    • +77
    ./stock-products/full-stock-card-summary-repository-impl.js
Revert "OLMIS-6328: Removed unnecessary call to /orderableFullfils"

This reverts commit 44989e3d

    • -37
    • +77
    ./stock-products/full-stock-card-summary-repository-impl.js
OLMIS-6328: Adjusted tests to support lack of calling fulfill endpoint

    • -18
    • +0
    ./stock-products/full-stock-card-summary-repository-impl.spec.js
OLMIS-6328: Adjusted tests to support lack of calling fulfill endpoint

    • -18
    • +0
    ./stock-products/full-stock-card-summary-repository-impl.spec.js
OLMIS-6328: Removed unnecessary call to /orderableFullfils

    • -77
    • +37
    ./stock-products/full-stock-card-summary-repository-impl.js
OLMIS-6328: Removed unnecessary call to /orderableFullfils

    • -77
    • +37
    ./stock-products/full-stock-card-summary-repository-impl.js
Remove one line of code

    • -1
    • +0
    ./stock-adjustment-creation/adjustment-creation.controller.spec.js
Then we can remove it here.

Then we can remove it here.

Nikodem Graczewski this is added to adjustment-creation.module.js. Did I miss anything?

Nikodem Graczewski this is added to adjustment-creation.module.js. Did I miss anything?

Address code review feedbacks.

    • -0
    • +1
    ./stock-adjustment-creation/adjustment-creation.module.js
    • -4
    • +4
    ./stock-unpack-kit/unpack-kit-constant.js
These should be added as a dependency to the adjustment-creation module.

These should be added as a dependency to the adjustment-creation module.

Refactor to:         return { KIT_UNPACK_REASON_ID': '@@KIT_UNPACK_REASON_ID', UNPACKED_FROM_KIT_REASON_ID': '@@UNPACKED_FROM_KIT_REASON_ID' };

Refactor to:

        
return {
    KIT_UNPACK_REASON_ID': '@@KIT_UNPACK_REASON_ID',
    UNPACKED_FROM_KIT_REASON_ID': '@@UNPACKED_FROM_KIT_REASON_ID'
};
OLMIS-6201: disallow choosing wrong unpack reason.
OLMIS-6201: disallow choosing wrong unpack reason.
OLMIS-6201: disallow choosing wrong unpack reason.

    • -8
    • +18
    ./stock-adjustment-creation/adjustment-creation.controller.js
    • -5
    • +6
    ./stock-adjustment-creation/adjustment-creation.controller.spec.js
    • -2
    • +2
    ./stock-adjustment-creation/adjustment-creation.html
    • -0
    • +36
    ./stock-unpack-kit/unpack-kit-constant.js
  1. … 1 more file in changeset.
I would prefer the original way

I would prefer the original way

I see. I would stick with the original approach then so we don't introduce any compatibility issues. However, we could use _.flatten instead. I'll leave it up to you.

I see. I would stick with the original approach then so we don't introduce any compatibility issues. However, we could use _.flatten instead. I'll leave it up to you.