Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4805: Updated Jenkinsfile and build.gradle to enable branch analysis

  1. … 1 more file in changeset.
maybe we could replace it with SONAR_BRANCH=$GIT_BRANCH?

maybe we could replace it with SONAR_BRANCH=$GIT_BRANCH?

OLMIS-4805: Enabled Sonar branch analysis
OLMIS-4805: Enabled Sonar branch analysis
I've created OLMIS-3867 to do this

I've created OLMIS-3867 to do this

ok, well this is fine for now

ok, well this is fine for now

because of missing this field sonar build fails

because of missing this field sonar build fails

I've created new ticket for dealing with running Karma tests with separate files: OLMIS-3844

I've created new ticket for dealing with running Karma tests with separate files: OLMIS-3844

Yea, I mean it should be probably in separate file. I've tried to set those properties as env variable but it does not work in sonar build like in standard ones.

Yea, I mean it should be probably in separate file. I've tried to set those properties as env variable but it does not work in sonar build like in standard ones.

Mateusz Kwiatkowski Thanks for updating this part

Mateusz Kwiatkowski Thanks for updating this part

This looks really weird.... I get that it is reading the project.properties file // but I wonder where documentation for this should go....

This looks really weird.... I get that it is reading the project.properties file // but I wonder where documentation for this should go....

Mateusz Kwiatkowski If the sonar.sh script is at /sonar.sh in the dev-ui, when built with docker it exists in the virtual machine's file system at /dev-ui/sonar.sh

Mateusz Kwiatkowski If the sonar.sh script is at /sonar.sh in the dev-ui, when built with docker it exists in the virtual machine's file system at /dev-ui/sonar.sh

Yeah, it's definitely worth filling a new ticket for this and move the discussion there.

Yeah, it's definitely worth filling a new ticket for this and move the discussion there.

It shouldn't change but who knows..... it is definitely more reliable to have it in service repo itself. Maybe we should create a short ticket about moving build.sh and sonar.sh to dev-ui? I'm not ...

It shouldn't change but who knows..... it is definitely more reliable to have it in service repo itself. Maybe we should create a short ticket about moving build.sh and sonar.sh to dev-ui? I'm not sure what folks from VR will think about it

As long as this path won't change I'm totally OK with that to be honest...

As long as this path won't change I'm totally OK with that to be honest...

That would be possible, but all dev-iu files are in /node_modules/dev-ui/ , I don't think we want to run script from there, but if you guys think otherwise I can move it there

That would be possible, but all dev-iu files are in /node_modules/dev-ui/ , I don't think we want to run script from there, but if you guys think otherwise I can move it there

If this will require more work maybe it would be good to create a separate ticket?

If this will require more work maybe it would be good to create a separate ticket?

It would be great if we could move sonar.sh file to the dev-ui but I am not sure if this is possible.

It would be great if we could move sonar.sh file to the dev-ui but I am not sure if this is possible.

please update http://docs.openlmis.org/en/latest/conventions/versioningReleasing.html as it refers to this file
I was removing this line

I was removing this line

I was removing this line

I was removing this line

I didn't figure out the code coverage, I've added some commented lines to show was I was trying to do. I would be grateful if someone could take a look at this because I'm out of ideas right now......

I didn't figure out the code coverage, I've added some commented lines to show was I was trying to do.
I would be grateful if someone could take a look at this because I'm out of ideas right now...
I'm getting something like "require is not defied" and "define is not defined" in jquery and perfect-scrollbar files, all proposed solutions suggested using browserify here but it didn't work. I've also tried to use chrome browser and bunch of other stuff which I don't remeber. The problem is that amdjs functions like require are not present in browser, but I'm not sure why this is working with openlmis.js but not with separate files... maybe something with order in files variable? (it was "copied" from javascript task)

I know that there is a lot of files in this review so review just dev-ui changes and referencedata-ui, other modules are duplicated mostly

I know that there is a lot of files in this review so review just dev-ui changes and referencedata-ui, other modules are duplicated mostly