gradle.properties

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4373: changed service version to new major version

added changelog entry

fixed javadoc in requsistion service class

  1. … 2 more files in changeset.
Yes

Yes

the UUID of the ...

the UUID of the ...

Is the comment removed?

Is the comment removed?

I agree. The duplicated files seem to have slight differences and are most likely coming from two different branches. Mateusz Kwiatkowski, could you fix up the review?

I agree. The duplicated files seem to have slight differences and are most likely coming from two different branches. Mateusz Kwiatkowski, could you fix up the review?

This is already done, check it out here: https://review.openlmis.org/cru/#FEOLMIS-3601CFR-48720

This is already done, check it out here: https://review.openlmis.org/cru/#FEOLMIS-3601CFR-48720

duplication of files make that the review is hard to read

duplication of files make that the review is hard to read

missing changelog

missing changelog

do we have ticket for that?

do we have ticket for that?

OLMIS-4373: removed filterBy option from requisitionsForConvert endpoint
OLMIS-4373: removed filterBy option from requisitionsForConvert endpoint
This is required by equals checker external library. Basically, because the class is not final it means that there are some subclasses and verifier wants to check if BaseDto class and subclass have...

This is required by equals checker external library. Basically, because the class is not final it means that there are some subclasses and verifier wants to check if BaseDto class and subclass have different equals method. I added the first class that extends the BaseDto class.

Yea I know but in this case I had to added new unit tests for DTO classes and when I started making changes I need to improve other part of the code https://review.openlmis.org/static/ogdo0b/2stati...

Yea I know but in this case I had to added new unit tests for DTO classes and when I started making changes I need to improve other part of the code

I assume that we basically did not add @ToString annotations to those classes and because my task was different I had not added the annotations to those classes.

I assume that we basically did not add @ToString annotations to those classes and because my task was different I had not added the annotations to those classes.

Thanks for improving the code. You don't need to do it for this review, but would it be possible to put the code improvements in a separate review? That way the review could be focused on the featu...

Thanks for improving the code. You don't need to do it for this review, but would it be possible to put the code improvements in a separate review? That way the review could be focused on the feature change.

I am curious as to why some test classes extend ToStringContractTest and others extend EqualsContractTest? Why do some classes not need a ToString?

I am curious as to why some test classes extend ToStringContractTest and others extend EqualsContractTest? Why do some classes not need a ToString?

I don't quite understand this? What if the BaseDto has nothing to do with a requisition?

I don't quite understand this? What if the BaseDto has nothing to do with a requisition?

OLMIS-5138: Added originalRequisition extended property to Requisition model
OLMIS-5138: Added originalRequisition extended property to Requisition model
copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

copy-paste

OLMIS-5138: Added originalRequisition extended field to Requisition model

  1. … 52 more files in changeset.
Bumped Requisition service version to 7.1.1-SNAPSHOT

Released Requisition service version 7.1.0

  1. … 1 more file in changeset.