Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5509: Fixed filtering offline requisitions
OLMIS-5509: Fixed filtering offline requisitions
OLMIS-5509: Fixed filtering offline requisitions

* Added unit tests for requisitionSearch filter

* Fixed a bug introduced during eslint fixes

* Added undefined/null and false distinction when comparing emergency property

  1. … 3 more files in changeset.
Fixed eslint issue

Restored old version of the should save requisition test

Reduced payload size when synchronizing requisition
Reduced payload size when synchronizing requisition
Added test for reducing requisition size when saving

Yep

Yep

are you sure this should be lower case string?

are you sure this should be lower case string?

Then that will be the point when we should make it global.

Then that will be the point when we should make it global.

I feel like this soon will be copy pasted couple of times though.

I feel like this soon will be copy pasted couple of times though.

It is only used in one place at the moment so we don't really need it globally (YAGNI).

It is only used in one place at the moment so we don't really need it globally (YAGNI).

I think that we should assign those values to this property to avoid memory leaks?

I think that we should assign those values to this property to avoid memory leaks?

can we maybe have this globally

can we maybe have this globally

Yep

Yep

are those messages available?

are those messages available?

I think you need to update this description and add return annotation

I think you need to update this description and add return annotation

Definitely not! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif Forgot about them!

Definitely not! Forgot about them!

this.this? Is that intentional?

this.this? Is that intentional?

It's safe to look at this file as completely new, to be honest.

It's safe to look at this file as completely new, to be honest.