openlmis-requisition-ui

Clone Tools

Stats

Commits this week: 8
Total Committers: 38
Last Commit:
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
11 mins ago

Łukasz Lewczyński and Klaudia Pałkowska

19 mins ago

Nikodem Graczewski

34 mins ago

Nikodem Graczewski

1 hr ago

Klaudia Pałkowska

1 hr ago

Nikodem Graczewski

Yep

Yep

Tuesday 16 Oct
3:16 pm

Mateusz Kwiatkowski

3:15 pm

Mateusz Kwiatkowski

are you sure this should be lower case string?

are you sure this should be lower case string?

3:14 pm

Mateusz Kwiatkowski and Łukasz Lewczyński

1:57 pm

Nikodem Graczewski

OLMIS-4251: Updated invalid JSDoc

Options
    • -2
    • +4
    /src/requisition-view-tab/requisition-view-tab.controller.js
    • -17
    • +17
    /src/requisition-view-tab/requisition-view-tab.controller.spec.js
1:51 pm

Nikodem Graczewski

OLMIS-4251: Reworked unit tests for SelectProductsModalController to not define any describe-scope variables

Options
    • -41
    • +40
    /src/select-products-modal/select-products-modal.controller.spec.js
1:43 pm

Nikodem Graczewski

Then that will be the point when we should make it global.

Then that will be the point when we should make it global.

1:29 pm

Mateusz Kwiatkowski

I feel like this soon will be copy pasted couple of times though.

I feel like this soon will be copy pasted couple of times though.

1:19 pm

Nikodem Graczewski

It is only used in one place at the moment so we don't really need it globally (YAGNI).

It is only used in one place at the moment so we don't really need it globally (YAGNI).

11:50 am

Mateusz Kwiatkowski

I think that we should assign those values to this property to avoid memory leaks?

I think that we should assign those values to this property to avoid memory leaks?

11:45 am

Mateusz Kwiatkowski

can we maybe have this globally

can we maybe have this globally

11:34 am

Nikodem Graczewski

Yep

Yep

11:34 am

Nikodem Graczewski

11:33 am

Nikodem Graczewski

11:27 am

Mateusz Kwiatkowski

are those messages available?

are those messages available?

11:17 am

Mateusz Kwiatkowski , Klaudia Pałkowska and Łukasz Lewczyński

11:17 am

Mateusz Kwiatkowski , Klaudia Pałkowska and Łukasz Lewczyński

9:53 am

Mateusz Kwiatkowski

I think you need to update this description and add return annotation

I think you need to update this description and add return annotation

8:53 am

Nikodem Graczewski

Definitely not! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif Forgot about them!

Definitely not! Forgot about them!

8:44 am

Klaudia Pałkowska

this.this? Is that intentional?

this.this? Is that intentional?

7:16 am

Nikodem Graczewski

It's safe to look at this file as completely new, to be honest.

It's safe to look at this file as completely new, to be honest.

7:16 am

Nikodem Graczewski

same here

same here

7:16 am

Nikodem Graczewski

same here

same here

7:15 am

Nikodem Graczewski

We're actually adding them here.

We're actually adding them here.

7:15 am

Nikodem Graczewski

These methods will work as intended (thanks to the .andCallThrough) so there is no need to multiply the build methods for spy and non-spy ones (YAGNI).

These methods will work as intended (thanks to the .andCallThrough) so there is no need to multiply the build methods for spy and non-spy ones (YAGNI).

7:12 am

Nikodem Graczewski

More like each time I need a spy on a method.

More like each time I need a spy on a method.