openlmis-requisition

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
AO-278: Change page size of requisitions search to max int

OLMIS-6270: Added missing data builders in service, utils, validate and web tests

OLMIS-6270: Added missing data builders in service, utils, validate and web tests
OLMIS-6270: Added missing data builders in service, utils, validate and web tests
OLMIS-6270: Added missing data builders in service, utils, validate and web tests

  1. … 5 more files in changeset.
OLMIS-6272: Added missing data builders in integration tests
OLMIS-6272: Added missing data builders in integration tests
OLMIS-6272: Added missing data builders in integration tests

OLMIS-6256: Added missing domain and dto data builder usages
OLMIS-6256: Added missing domain and dto data builder usages
OLMIS-6256: Added missing domain and dto data builder usages

OLMIS-6037: Standardize build statuses for all our Jenkins jobs
OLMIS-6037: Standardize build statuses for all our Jenkins jobs
Updated total losses and adjustments to equal -2

OLMIS-6037: Added unstable build status for testing failures

Revert "OLMIS-6037: Standardize build statuses for all our Jenkins jobs"

This reverts commit d770ebf1a67fd7017ec9e11a08fb1699f4347b7d.

OLMIS-6037: Standardize build statuses for all our Jenkins jobs

WIP

Ok. The duplication in the data builders has been removed. Exporter pattern is used where it's possible in the data buiders.

Ok. The duplication in the data builders has been removed. Exporter pattern is used where it's possible in the data buiders.

WIP

WIP

WIP

OLMIS-6256: Removed duplication in databuilders, used export pattern for DTOs

  1. … 114 more files in changeset.
WIP

WIP

According to the DRY principle, we should not be duplicating code, especially that much. 1. Instead of adding another data builder we could add a buildDto method which would abstract the exporting ...

According to the DRY principle, we should not be duplicating code, especially that much.
1. Instead of adding another data builder we could add a buildDto method which would abstract the exporting part. This way we have both fast and easily used builders as well as no code duplication.
2. So can be using the DataBuilder pattern and duplicating such a big chunk of the code. As long as the complexity is low, and it is the same for a separate builder and using the exporter pattern, we should be good.
3. Same is true using the exporter pattern.