20170724135757991__jasper_template_add_required_rights_relation.sql

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LGTM

LGTM

Paweł Nawrocki I meant use AssertJ assertThatThrownBy. Do we use it in olmis?

Paweł Nawrocki I meant use AssertJ assertThatThrownBy. Do we use it in olmis?

shouldReject

shouldReject

never executed

never executed

never executed

never executed

never executed

never executed

It's never executed. Use ExpectedException instead of annotation

It's never executed. Use ExpectedException instead of annotation

what about 2 good case scenarios for saveTemplate method?

what about 2 good case scenarios for saveTemplate method?

Paweł Albecki review updated

Paweł Albecki review updated

OLMIS-2760: Added Facility Assignment Configuration Errors report, fixed required_rights migration and added demo data

    • -2
    • +2
    ./20170724135757991__jasper_template_add_required_rights_relation.sql
  1. … 10 more files in changeset.
guess there are no matchers for arrays

guess there are no matchers for arrays

do we have tests for this?

do we have tests for this?

add unit tests for this class

add unit tests for this class

add unit test

add unit test

Can we replace any with array of rights?

Can we replace any with array of rights?

Don't we need CollectionTable annotation here?

Don't we need CollectionTable annotation here?

fk not pk

fk not pk

update json schema

update json schema

add information about exception

add information about exception

OLMIS-2760: Added requiredRights parameter to jasper templates
OLMIS-2760: Added requiredRights parameter to jasper templates
OLMIS-2760: Added requiredRights parameter to jasper template

    • -0
    • +16
    ./20170724135757991__jasper_template_add_required_rights_relation.sql
  1. … 7 more files in changeset.